From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH net-next v1 08/21] net: usb: lan78xx: Add error handling to set_rx_max_frame_length and set_mtu
Date: Tue, 3 Dec 2024 21:37:40 +0100 [thread overview]
Message-ID: <8467b5b4-e432-445e-b399-cf30aa32d467@lunn.ch> (raw)
In-Reply-To: <20241203072154.2440034-9-o.rempel@pengutronix.de>
On Tue, Dec 03, 2024 at 08:21:41AM +0100, Oleksij Rempel wrote:
> Improve error handling in `lan78xx_set_rx_max_frame_length` by:
> - Checking return values from register read/write operations and
> propagating errors.
> - Exiting immediately on failure to ensure proper error reporting.
>
> In `lan78xx_change_mtu`, log errors when changing MTU fails, using `%pe`
> for clear error representation.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-12-03 20:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 7:21 [PATCH net-next v1 00/21] lan78xx: Preparations for PHYlink Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 01/21] net: usb: lan78xx: Remove LAN8835 PHY fixup Oleksij Rempel
2024-12-03 20:26 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 02/21] net: usb: lan78xx: Remove KSZ9031 " Oleksij Rempel
2024-12-03 20:29 ` Andrew Lunn
2024-12-05 17:12 ` Simon Horman
2024-12-06 8:56 ` Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 03/21] net: usb: lan78xx: move functions to avoid forward definitions Oleksij Rempel
2024-12-03 20:29 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 04/21] net: usb: lan78xx: Improve error reporting with %pe specifier Oleksij Rempel
2024-12-03 20:30 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 05/21] net: usb: lan78xx: Fix error handling in MII read/write functions Oleksij Rempel
2024-12-03 20:31 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 06/21] net: usb: lan78xx: Improve error handling in EEPROM and OTP operations Oleksij Rempel
2024-12-03 20:35 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 07/21] net: usb: lan78xx: Add error handling to lan78xx_init_ltm Oleksij Rempel
2024-12-03 20:36 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 08/21] net: usb: lan78xx: Add error handling to set_rx_max_frame_length and set_mtu Oleksij Rempel
2024-12-03 20:37 ` Andrew Lunn [this message]
2024-12-03 7:21 ` [PATCH net-next v1 09/21] net: usb: lan78xx: Add error handling to lan78xx_irq_bus_sync_unlock Oleksij Rempel
2024-12-03 20:38 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 10/21] net: usb: lan78xx: Improve error handling in dataport and multicast writes Oleksij Rempel
2024-12-03 20:39 ` Andrew Lunn
2024-12-03 7:21 ` [PATCH net-next v1 11/21] net: usb: lan78xx: Add error handling to lan78xx_setup_irq_domain Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 12/21] net: usb: lan78xx: Add error handling to lan78xx_init_mac_address Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 13/21] net: usb: lan78xx: Add error handling to lan78xx_set_mac_addr Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 14/21] net: usb: lan78xx: Add error handling to lan78xx_get_regs Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 15/21] net: usb: lan78xx: Simplify lan78xx_update_reg Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 16/21] net: usb: lan78xx: Fix return value handling in lan78xx_set_features Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 17/21] net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop_hw Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 18/21] net: usb: lan78xx: Use function-specific label in lan78xx_mac_reset Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 19/21] net: usb: lan78xx: Improve error handling in lan78xx_phy_wait_not_busy Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 20/21] net: usb: lan78xx: Rename lan78xx_phy_wait_not_busy to lan78xx_mdiobus_wait_not_busy Oleksij Rempel
2024-12-03 7:21 ` [PATCH net-next v1 21/21] net: usb: lan78xx: Improve error handling in WoL operations Oleksij Rempel
2024-12-03 20:23 ` [PATCH net-next v1 00/21] lan78xx: Preparations for PHYlink Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8467b5b4-e432-445e-b399-cf30aa32d467@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox