public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de,
	ratbert@faraday-tech.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/7] net: faraday: Add ARM64 in FTGMAC100 for AST2700
Date: Mon, 25 Nov 2024 17:12:47 +0100	[thread overview]
Message-ID: <846e2d7e-33bf-4aa5-8e33-e2c4fffb4f7a@kernel.org> (raw)
In-Reply-To: <20241120075017.2590228-3-jacky_chou@aspeedtech.com>

On 20/11/2024 08:50, Jacky Chou wrote:
> AST2700 is a ARM 64-bit SoC and ftgmac100 adds support 64-bit
> DMA capability in AST2700.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  drivers/net/ethernet/faraday/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig
> index c699bd6bcbb9..d5a088d88c3d 100644
> --- a/drivers/net/ethernet/faraday/Kconfig
> +++ b/drivers/net/ethernet/faraday/Kconfig
> @@ -6,7 +6,7 @@
>  config NET_VENDOR_FARADAY
>  	bool "Faraday devices"
>  	default y
> -	depends on ARM || COMPILE_TEST
> +	depends on ARM || ARM64 || COMPILE_TEST
>  	help
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>  
> @@ -28,8 +28,7 @@ config FTMAC100
>  
>  config FTGMAC100
>  	tristate "Faraday FTGMAC100 Gigabit Ethernet support"
> -	depends on ARM || COMPILE_TEST
> -	depends on !64BIT || BROKEN
Explain in commit msg how did you unbreak it. Better, combine it with
commit which actually fixes broken 64bit.

Best regards,
Krzysztof

  reply	other threads:[~2024-11-25 16:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20  7:50 [PATCH net-next v3 0/7] Add Aspeed G7 FTGMAC100 support Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700 Jacky Chou
2024-11-25 10:24   ` Philipp Zabel
2024-11-25 16:13     ` Krzysztof Kozlowski
2024-11-27  3:57       ` 回覆: " Jacky Chou
2024-11-27  3:50     ` Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 2/7] net: faraday: Add ARM64 in FTGMAC100 " Jacky Chou
2024-11-25 16:12   ` Krzysztof Kozlowski [this message]
2024-11-20  7:50 ` [PATCH net-next v3 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs Jacky Chou
2024-11-25 10:27   ` Philipp Zabel
2024-11-27  3:48     ` 回覆: " Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 4/7] net: ftgmac100: Add support for AST2700 Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 5/7] net: ftgmac100: add pin strap configuration " Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 6/7] net: ftgmac100: Add 64-bit DMA support " Jacky Chou
2024-11-20  7:50 ` [PATCH net-next v3 7/7] net: ftgmac100: remove extra newline symbols Jacky Chou
2024-11-21  8:41 ` [PATCH net-next v3 0/7] Add Aspeed G7 FTGMAC100 support Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=846e2d7e-33bf-4aa5-8e33-e2c4fffb4f7a@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=jacky_chou@aspeedtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=ratbert@faraday-tech.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox