From: "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
To: "Luben Tuikov" <luben.tuikov@amd.com>,
"Asahi Lina" <lina@asahilina.net>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: "Faith Ekstrand" <faith.ekstrand@collabora.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
asahi@lists.linux.dev, "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.
Date: Wed, 19 Jul 2023 18:16:36 +0000 [thread overview]
Message-ID: <847159ff6d0c01cef2e6308848ea49a732248e42@linux.dev> (raw)
In-Reply-To: <41efcbe5-e230-270f-53bb-90c703e9d3ad@amd.com>
July 18, 2023 at 1:14 AM, "Luben Tuikov" <luben.tuikov@amd.com> wrote:
> > > Not sure about other drivers--they can speak for themselves and the CC list
> > > should include them--please use "dim add-missing-cc" and make sure
> > > that the Git commit description contains the Cc tags--then git send-email
> > > will populate the SMTP CC. Feel free to add more Cc tags on top of that.
> >
> > I use `b4 prep -c` which I think does the same thing? I just ran it
> > again and it only added 'linaro-mm-sig@lists.linaro.org', not sure why
> > that one wasn't there. Am I missing anything else?
>
> Not sure about "b4 prep -c"--using "git send-email" instead, but what is
> important is to add the Cc: tags as part of the commit message. A "git log" of
> drm-misc-next shows the proper format. Then maintainers add Link:
> tag to the correct email thread, which is usually completely automated
> by "dim" or by "git am", or both.
It's useful to note here that this is not standard practice across the entirety of the Linux tree. In general, Cc: trailers are added to individual commits when get_maintainer.pl wouldn't otherwise include someone in the recipient list. The "dim" tool mentioned here is specific to the DRM subsystem (the "d" stands for "DRM"). Since both tools work on git series, you can use it alongside b4.
DRM folks, if get_maintainer.pl isn't finding someone who should be included on a series of patches, should the MAINTAINERS file be updated to make it easier to submit valid patches without needing to know of "dim"?
Regards,
-K
next prev parent reply other threads:[~2023-07-19 18:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:21 [PATCH 0/3] DRM scheduler documentation & bug fixes Asahi Lina
2023-07-14 8:21 ` [PATCH 1/3] drm/scheduler: Add more documentation Asahi Lina
2023-07-14 8:40 ` Christian König
2023-07-14 9:39 ` Asahi Lina
2023-07-14 9:47 ` Christian König
2023-07-14 9:51 ` Asahi Lina
2023-07-14 8:21 ` [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name Asahi Lina
2023-07-14 8:43 ` Christian König
2023-07-14 9:44 ` Asahi Lina
2023-07-14 9:51 ` Christian König
2023-07-14 10:07 ` Asahi Lina
2023-07-14 10:29 ` Christian König
2023-07-14 9:49 ` Asahi Lina
2023-07-14 9:57 ` Christian König
2023-07-14 10:06 ` Asahi Lina
2023-07-14 10:18 ` Christian König
2023-07-14 12:13 ` Asahi Lina
2023-07-15 4:03 ` Luben Tuikov
2023-07-15 14:14 ` alyssa
2023-07-17 15:55 ` Christian König
2023-07-18 2:35 ` Asahi Lina
2023-07-18 5:45 ` Luben Tuikov
2023-07-21 10:33 ` Asahi Lina
2023-07-31 8:09 ` Christian König
2023-11-01 6:59 ` Dave Airlie
2023-11-01 8:13 ` Daniel Vetter
2023-11-02 10:48 ` Christian König
2023-11-02 11:19 ` Lucas Stach
2023-11-02 12:39 ` Christian König
2023-07-28 7:48 ` Christian König
2023-07-18 8:21 ` Pekka Paalanen
2023-07-14 8:21 ` [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down Asahi Lina
2023-07-15 7:14 ` Luben Tuikov
2023-07-16 7:51 ` Asahi Lina
2023-07-17 17:40 ` Luben Tuikov
2023-07-17 22:45 ` Asahi Lina
2023-07-18 5:14 ` Luben Tuikov
2023-07-19 18:16 ` Konstantin Ryabitsev [this message]
2023-07-19 18:58 ` Luben Tuikov
2023-08-02 4:06 ` Matthew Brost
2023-08-02 14:12 ` Luben Tuikov
2023-07-19 8:45 ` Christian König
2023-07-19 15:05 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=847159ff6d0c01cef2e6308848ea49a732248e42@linux.dev \
--to=konstantin.ryabitsev@linux.dev \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox