From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>, Andrew Hunter <ahh@google.com>,
maged michael <maged.michael@gmail.com>,
Avi Kivity <avi@scylladb.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Dave Watson <davejwatson@fb.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrea Parri <parri.andrea@gmail.com>,
"Russell King, ARM Linux" <linux@armlinux.org.uk>,
Greg Hackmann <ghackmann@google.com>,
Will Deacon <will.deacon@arm.com>, David Sehr <sehr@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86 <x86@kernel.org>, linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH for 4.16 08/10] membarrier: x86: Provide core serializing command (v3)
Date: Tue, 16 Jan 2018 20:41:09 +0000 (UTC) [thread overview]
Message-ID: <84882000.4019.1516135269345.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <1443621141.3981.1516130533202.JavaMail.zimbra@efficios.com>
----- On Jan 16, 2018, at 2:22 PM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
> ----- On Jan 16, 2018, at 1:29 PM, Thomas Gleixner tglx@linutronix.de wrote:
>
>> On Mon, 15 Jan 2018, Mathieu Desnoyers wrote:
>>
>>> There are two places where core serialization is needed by membarrier:
>>>
>>> 1) When returning from the membarrier IPI,
>>> 2) After scheduler updates curr to a thread with a different mm, before
>>> going back to user-space, since the curr->mm is used by membarrier to
>>> check whether it needs to send an IPI to that CPU.
>>
>> This wants to be split into x86 and core changes. Ideally you make the core
>> changes before the previous patch and add the empty inline into
>> linux/processor.h....
>
> Good point, done. The first commit introducing the new command now also
> introduces the generic stuff moved from the x86 patches.
Scratch this: it's cleaner if I add a separate generic patch to introduce
just the empty inline into linux/processor.h and the
ARCH_HAS_SYNC_CORE_BEFORE_USERMODE in init/Kconfig.
Thanks,
Mathieu
>
> Thanks,
>
> Mathieu
>
>>
>> Thanks,
>>
>> tglx
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2018-01-16 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 19:10 [PATCH for 4.16 00/10] membarrier updates for 4.16 Mathieu Desnoyers
2018-01-15 19:10 ` [PATCH for 4.16 01/10] membarrier: selftest: Test private expedited cmd (v2) Mathieu Desnoyers
2018-01-15 19:10 ` [PATCH for 4.16 02/10] powerpc: membarrier: Skip memory barrier in switch_mm() (v7) Mathieu Desnoyers
2018-01-15 19:10 ` [PATCH for 4.16 03/10] membarrier: Document scheduler barrier requirements (v5) Mathieu Desnoyers
2018-01-15 19:10 ` [PATCH for 4.16 04/10] membarrier: provide SHARED_EXPEDITED command (v2) Mathieu Desnoyers
2018-01-16 18:20 ` Thomas Gleixner
2018-01-16 19:02 ` Mathieu Desnoyers
2018-01-16 19:04 ` Thomas Gleixner
2018-01-15 19:10 ` [PATCH for 4.16 05/10] membarrier: selftest: Test shared expedited cmd Mathieu Desnoyers
2018-01-15 19:11 ` [PATCH for 4.16 06/10] membarrier: Provide core serializing command Mathieu Desnoyers
2018-01-15 19:11 ` [PATCH for 4.16 07/10] x86: Introduce sync_core_before_usermode (v2) Mathieu Desnoyers
2018-01-16 18:28 ` Thomas Gleixner
2018-01-15 19:11 ` [PATCH for 4.16 08/10] membarrier: x86: Provide core serializing command (v3) Mathieu Desnoyers
2018-01-16 18:29 ` Thomas Gleixner
2018-01-16 19:22 ` Mathieu Desnoyers
2018-01-16 20:41 ` Mathieu Desnoyers [this message]
2018-01-15 19:11 ` [PATCH for 4.16 09/10] membarrier: arm64: Provide core serializing command Mathieu Desnoyers
2018-01-15 19:11 ` [PATCH for 4.16 10/10] membarrier: selftest: Test private expedited sync core cmd Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84882000.4019.1516135269345.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=ahh@google.com \
--cc=avi@scylladb.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=davejwatson@fb.com \
--cc=ghackmann@google.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=maged.michael@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=parri.andrea@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sehr@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox