From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yulin Lu <luyulin@eswincomputing.com>,
dlemoal@kernel.org, cassel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
kishon@kernel.org, linux-phy@lists.infradead.org
Cc: ningyu@eswincomputing.com, zhengyu@eswincomputing.com,
linmin@eswincomputing.com, huangyifeng@eswincomputing.com,
fenglin@eswincomputing.com, lianghujun@eswincomputing.com
Subject: Re: [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci
Date: Thu, 4 Sep 2025 09:10:34 +0200 [thread overview]
Message-ID: <8489c13b-6810-480c-9894-bb5c80cfbde0@kernel.org> (raw)
In-Reply-To: <20250904063718.421-1-luyulin@eswincomputing.com>
On 04/09/2025 08:37, Yulin Lu wrote:
> Add document for the SATA AHCI controller on the EIC7700 SoC platform,
Subject: drop "for", wrong grammar. "Document" is a verb.
> including descriptions of its hardware configurations.
>
> Signed-off-by: Yulin Lu <luyulin@eswincomputing.com>
...
> +
> +maintainers:
> + - Yulin Lu <luyulin@eswincomputing.com>
> + - Huan He <hehuan1@eswincomputing.com>
> +
> +description:
> + This document defines device tree bindings for the Synopsys DWC
Describe the hardware, not the document. Entire line is completely
redundant.
> + implementation of the AHCI SATA controller found in Eswin's
> + Eic7700 SoC platform.
> +
...
> + clock-names:
> + items:
> + - const: pclk
> + - const: aclk
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: arst
> +
> + ports-implemented:
> + const: 1
I do not see how you addressed request about firmware. Nothing changed
here, no explanation in the commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-04 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:34 [PATCH v3 0/3] Add driver support for Eswin EIC7700 SoC SATA Controller and PHY Yulin Lu
2025-09-04 6:37 ` [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci Yulin Lu
2025-09-04 7:10 ` Krzysztof Kozlowski [this message]
2025-09-04 9:14 ` Niklas Cassel
2025-09-04 9:50 ` Krzysztof Kozlowski
2025-09-05 7:23 ` luyulin
2025-09-04 6:38 ` [PATCH v3 2/3] dt-bindings: phy: eswin: Document for EIC7700 SoC SATA PHY Yulin Lu
2025-09-04 7:11 ` Krzysztof Kozlowski
2025-09-04 6:38 ` [PATCH v3 3/3] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver Yulin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8489c13b-6810-480c-9894-bb5c80cfbde0@kernel.org \
--to=krzk@kernel.org \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=fenglin@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lianghujun@eswincomputing.com \
--cc=linmin@eswincomputing.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhengyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox