From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B404A14B959 for ; Wed, 15 Jan 2025 23:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736982973; cv=none; b=BJ/j+mWSJdpPE0AUNb7705g+MoJYywRTZ/r6GaiuY1mhiFIlzYHXPXg+kwcY5pZmmtmhgre2rNQ9TpavHES5AfzHULwtmE8Pq4MwwxIvdIj49Ae/dM7cikdNVaYk3uw3d6zwG7YyEtLXKtT67oiUvlwDAIyxOZllvpYr3GO7Xfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736982973; c=relaxed/simple; bh=3zIKod6x6p/3kPY13t63j93xA6NahssLaW2A/NKgW4I=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=ObVmvHGmQJ0IMoGX98wJZ5WzbzcSjdgHonajrvvakckLwNTrML2BF40BrajjxmlGMRLU25sgDm9QriCy5wN7HqmeI1xg0C3FeI+kkaA7uiY81rlGoV6uyru9TG2ZjZuAhNKamU/7E3vL18PK5SLSbrlSLvrGLXEqTkJTLEJ4E70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iHehGmGF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iHehGmGF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26B33C4CED1; Wed, 15 Jan 2025 23:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736982973; bh=3zIKod6x6p/3kPY13t63j93xA6NahssLaW2A/NKgW4I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=iHehGmGFX02DEW3nQTnGkhXM3MgDB5BxaPXg/ZluMx1nwHpBdHNp7iK2MZSo2+G/h fCmL/jNkHgrnqULTGDoiVwSZlH80YJhYETrtmNkpcxAkjl4xdsJxVkhq+wQEDNe0EV 6PYXvXBZKgB/LGGvnqQFA7y+TNGQpf/k0EPywX68pHReUY6FkjYGIAAgPNHanXDGSY +yPJR7WV2E6d0NCaNXSf6dCPS07vGkeLyoweLNZ19XvqV1qF+MTyT9+hy30jloN4Vp ZdpQvMRPaDnHexGYDqqfv44uLBzYQxfYlC2dsdpw2+fz8A7RSo519PFSaHSP3fOFOy GwkUA7NphGP4g== Message-ID: <848b4dad4f38dc6545b97f7c5007e514.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <91e2bd5b-71fa-402a-82cb-e68d3295804a@gmail.com> References: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com> <5b139af8d639e20a14c8bd00e8e03a4a.sboyd@kernel.org> <58cb6c37-0ea0-4866-a2b1-92cb0f0391a7@gmail.com> <305d7cf5f0a66efc01181f24d3a288d3.sboyd@kernel.org> <91e2bd5b-71fa-402a-82cb-e68d3295804a@gmail.com> Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage From: Stephen Boyd Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Johan Hovold , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Konrad Dybcio To: AngeloGioacchino Del Regno , Joe Hattori , Konrad Dybcio , Konrad Dybcio , Matthias Brugger , Mauro Carvalho Chehab Date: Wed, 15 Jan 2025 15:16:10 -0800 User-Agent: alot/0.12.dev1+gaa8c22fdeedb Quoting Konrad Dybcio (2025-01-14 12:37:20) > On 1/14/25 19:30, Stephen Boyd wrote: > >=20 > > Ok, I see that I was reading the already reverted state of the tree > > where the 'ctrl->dev.of_node =3D node' assignment came back. So there's > > nothing to do besides drop the patch in fixes, which I already did. We > > can then apply this patch to drop the duplicate assignment as a cleanup > > and to avoid a refcount bump on the of_node that isn't needed. > >=20 > > ----8<--- > > diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-sp= mi-controller.c > > index 3cafdf22c909..122140b97579 100644 > > --- a/drivers/spmi/hisi-spmi-controller.c > > +++ b/drivers/spmi/hisi-spmi-controller.c > > @@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_de= vice *pdev) > > =20 > > spin_lock_init(&spmi_controller->lock); > > =20 > > - ctrl->dev.parent =3D pdev->dev.parent; > > - ctrl->dev.of_node =3D of_node_get(pdev->dev.of_node); > > - > > /* Callbacks */ > > ctrl->read_cmd =3D spmi_read_cmd; > > ctrl->write_cmd =3D spmi_write_cmd; >=20 > That works for me, thank you >=20 Joe, care to send this patch to replace the one you sent previously?