From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Dawei Li <dawei.li@shingroup.cn>,
will@kernel.org, mark.rutland@arm.com, yury.norov@gmail.com,
linux@rasmusvillemoes.dk
Cc: renyu.zj@linux.alibaba.com, yangyicong@hisilicon.com,
jonathan.cameron@huawei.com, andersson@kernel.org,
konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 02/10] perf/alibaba_uncore_drw: Avoid placing cpumask on the stack
Date: Mon, 8 Apr 2024 08:28:29 +0800 [thread overview]
Message-ID: <8490280b-2ae2-4a0f-a13b-c2afc9e2b2ed@linux.alibaba.com> (raw)
In-Reply-To: <20240403155950.2068109-3-dawei.li@shingroup.cn>
On 2024/4/3 23:59, Dawei Li wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>
next prev parent reply other threads:[~2024-04-08 0:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 15:59 [PATCH v3 00/10] perf: Avoid placing cpumask on the stack Dawei Li
2024-04-03 15:59 ` [PATCH v3 01/10] cpumask: add cpumask_any_and_but() Dawei Li
2024-04-03 16:31 ` Yury Norov
2024-04-03 15:59 ` [PATCH v3 02/10] perf/alibaba_uncore_drw: Avoid placing cpumask on the stack Dawei Li
2024-04-08 0:28 ` Shuai Xue [this message]
2024-04-03 15:59 ` [PATCH v3 03/10] perf/arm-cmn: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 04/10] perf/arm_cspmu: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 05/10] perf/arm_dsu: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 06/10] perf/dwc_pcie: " Dawei Li
2024-04-08 0:30 ` Shuai Xue
2024-04-03 15:59 ` [PATCH v3 07/10] perf/hisi_pcie: " Dawei Li
2024-04-05 9:54 ` Jonathan Cameron
2024-04-03 15:59 ` [PATCH v3 08/10] perf/hisi_uncore: " Dawei Li
2024-04-05 9:54 ` Jonathan Cameron
2024-04-03 15:59 ` [PATCH v3 09/10] perf/qcom_l2: " Dawei Li
2024-04-03 15:59 ` [PATCH v3 10/10] perf/thunderx2: " Dawei Li
2024-04-09 16:59 ` [PATCH v3 00/10] perf: " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8490280b-2ae2-4a0f-a13b-c2afc9e2b2ed@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=andersson@kernel.org \
--cc=dawei.li@shingroup.cn \
--cc=jonathan.cameron@huawei.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox