Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_

Chris Wilson
2011-02-09T09:32:15Z

On Wed, 9 Feb 2011 03:56:36 +0100 (CET), "Indan Zupancic" <indan@nul.nu> wrote:
> All in all it seems quite wrong, no matter if it happens to work, because
> it depends on the calling order done by the drm layer. If *_crtc_enable()
> is called instead it won't do anything because of that active = true thing.
> This seems to be happening in your case.

The order is very well defined.

modesetting (upon resume we set the previous mode):
for each enabled crtc:
crtc_helper->prepare -> intel_crtc_disable()
crtc->mode_set -> intel_crtc_mode_set()
crtc_helper->commit -> intel_crtc_enable()
for each !enabled crtc:
crtc->disable -> intel_crtc_disable()
-Chris

--
Chris Wilson, Intel Open Source Technology Centre