Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_

Chris Wilson
2011-02-08T13:36:12Z

On Mon, 7 Feb 2011 22:11:29 +0800, Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> Same issue encountered even after a fresh build.

I've been testing on the same hardware (x201s, 64bit, with and without
external DP) and I've not encountered the same issue. Every time I look
at the code, by not setting crtc->active we may incorrectly skip disabling
an active output after resume. If the output is inactive, then disabling it
*should* be a no-op, and thus safe. So I am still at a loss to understand
what fails here and so whether we have a bigger problem on our hands.

Please can you add drm.debug=0xe to your boot parameters (or echo 0xe >
/sys/module/drm/parameters/debug might just be enough) and attach the
dmesg whilst resuming. Also attaching the failing Xorg.0.log would be
useful to rule out any other issues.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre