Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_

Takashi Iwai
2011-02-06T11:02:34Z

At Sun, 6 Feb 2011 09:19:51 +0100,
Marc Koschewski wrote:
>
> Hi,
>
> * Jeff Chua <jeff.chua.linux@gmail.com> [2011-02-06 09:50:51 +0800]:
> > On Sun, Feb 6, 2011 at 2:24 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > >> The suspend monster is back! The suspend-to-ram is fine, but upon
> > >> resume, screen is blank. Haven't bisected in case someone has also
> > >> done so.
> > >
> > > BTW, please don't reply to messages containing patches with reports of problems
> > > that aren't caused by those patches. It's confusing at best and at worst it
> > > may result in the patches being rejected.
> >
> > Sorry. New subject now:)
> >
> >
> > On Sun, Feb 6, 2011 at 2:51 AM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >> It's very recent. ... between commit
> > >> 831d52bc153971b70e64eccfbed2b232394f22f8 and
> > >> 44f2c5c841da1b1e0864d768197ab1497b5c2cc1.
> > >
> > > Hmm. It's almost certainly one of the DRI patches, but which one? I
> > > think bisection is the only way to figure it out. It shouldn't be too
> > > bad, since there's only 120 commits in that range.
> > >
> > > In fact, you can almost certainly just bisect from 89840966c579 to
> > > bb5b583b5279, which is just 31 commits and should get you bisected in
> > > just five tries or so.
> >
> > Yea, I've just done that. It came down to the following commit.
> > Reverting it solves the problem. I've gone thru a few cycles, and
> > notebook still survives.
> >
> > Thanks,
> > Jeff
>
> I reverted the specified commit and my box still suffers the
> resume-turns-into-cold-boot behavior. Retried two times with the commit reverted
> on top of HEAD...

The cold-boot problem is very likely irrelevant with i915 patches.
I've got the same issue with and without the i915 fix patches on test
machines here.

thanks,

Takashi