Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_

Rafael J. Wysocki
2011-02-07T21:20:41Z

On Monday, February 07, 2011, Jeff Chua wrote:
> On Mon, Feb 7, 2011 at 9:38 PM, Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> > On Mon, Feb 7, 2011 at 6:15 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >>> Thanks, that looks good. What about other files? Did you change
> >>> (especially intel_drv.h) from Linus git tree?
> >
> > I will try again from a fresh build tonight.
> >
> >>> I'll also check later to be sure (now I have no machine for testing).
> >> I don't see any problem with my machine (but running in 32bit).
> >>
> >> Are you sure that you are seeing the same CRTC? There are two active
> >> CRTCs on Intel, and both are initialized and set up.
> >
> > I don't know about that. Even when I attempt to just the pointer
> > directly as in "static void intel_crtc_reset(struct intel_crtc
> > *intel_crtc)", it ended up getting a different value. Strange.
> >
> > intel_crtc ffff880239aa5800
> > intel_crtc ffff880239aa5000
> >
> >
> > I'm building everything fresh now.
>
> Same issue encountered even after a fresh build.

So, can you confirm that on your machine the issue is 100% reproducible and
it goes away after reverting

commit 5d1d0cc87fc0887921993ea0742932e0c8adeda0
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon Jan 24 15:02:15 2011 +0000

drm/i915: Reset crtc after resume

?

Rafael