Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_

Marc Koschewski
2011-02-06T08:20:07Z

Hi,

* Jeff Chua <jeff.chua.linux@gmail.com> [2011-02-06 09:50:51 +0800]:
> On Sun, Feb 6, 2011 at 2:24 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> The suspend monster is back! The suspend-to-ram is fine, but upon
> >> resume, screen is blank. Haven't bisected in case someone has also
> >> done so.
> >
> > BTW, please don't reply to messages containing patches with reports of problems
> > that aren't caused by those patches. It's confusing at best and at worst it
> > may result in the patches being rejected.
>
> Sorry. New subject now:)
>
>
> On Sun, Feb 6, 2011 at 2:51 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >> It's very recent. ... between commit
> >> 831d52bc153971b70e64eccfbed2b232394f22f8 and
> >> 44f2c5c841da1b1e0864d768197ab1497b5c2cc1.
> >
> > Hmm. It's almost certainly one of the DRI patches, but which one? I
> > think bisection is the only way to figure it out. It shouldn't be too
> > bad, since there's only 120 commits in that range.
> >
> > In fact, you can almost certainly just bisect from 89840966c579 to
> > bb5b583b5279, which is just 31 commits and should get you bisected in
> > just five tries or so.
>
> Yea, I've just done that. It came down to the following commit.
> Reverting it solves the problem. I've gone thru a few cycles, and
> notebook still survives.
>
> Thanks,
> Jeff

I reverted the specified commit and my box still suffers the
resume-turns-into-cold-boot behavior. Retried two times with the commit reverted
on top of HEAD...

Regards,
Marc

>
>
> commit 500f7147cf5bafd139056d521536b10c2bc2e154
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Mon Jan 24 15:14:41 2011 +0000
>
> drm/i915: Reset state after a GPU reset or resume
>
> Call drm_mode_config_reset() after an invalidation event to restore any
> cached state to unknown.
>
> Tested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>

--
Marc Koschewski