Re: [PATCH 5/7] perf/x86/intel: Add core PMU support for Novalake

["Mi, Dapeng" <dapeng1.mi@linux.intel.com>]

On 1/9/2026 3:35 AM, Chen, Zide wrote:
>
> On 11/19/2025 9:34 PM, Dapeng Mi wrote:
>> This patch enables core PMU support for Novalake, covering both P-core
>> and E-core. It includes Arctic Wolf-specific counters, PEBS constraints,
>> and the OMR registers table.
>>
>> Since Coyote Cove shares the same PMU capabilities as Panther Cove, the
>> existing Panther Cove PMU enabling functions are reused for Coyote Cove.
>>
>> For detailed information about counter constraints, please refer to
>> section 16.3 "COUNTER RESTRICTIONS" in the ISE documentation.
>>
>> ISE: https://www.intel.com/content/www/us/en/content-details/869288/intel-architecture-instruction-set-extensions-programming-reference.html
>>
>> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>> ---
>>  arch/x86/events/intel/core.c | 99 ++++++++++++++++++++++++++++++++++++
>>  arch/x86/events/intel/ds.c   | 11 ++++
>>  arch/x86/events/perf_event.h |  2 +
>>  3 files changed, 112 insertions(+)
>>
>> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
>> index 9f2a93fe23df..a3a1e6e670f8 100644
>> --- a/arch/x86/events/intel/core.c
>> +++ b/arch/x86/events/intel/core.c
>> @@ -232,6 +232,29 @@ static struct event_constraint intel_skt_event_constraints[] __read_mostly = {
>>  	EVENT_CONSTRAINT_END
>>  };
>>  
>> +static struct event_constraint intel_arw_event_constraints[] __read_mostly = {
>> +	FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
>> +	FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
>> +	FIXED_EVENT_CONSTRAINT(0x0300, 2), /* pseudo CPU_CLK_UNHALTED.REF */
>> +	FIXED_EVENT_CONSTRAINT(0x013c, 2), /* CPU_CLK_UNHALTED.REF_TSC_P */
>> +	FIXED_EVENT_CONSTRAINT(0x0073, 4), /* TOPDOWN_BAD_SPECULATION.ALL */
>> +	FIXED_EVENT_CONSTRAINT(0x019c, 5), /* TOPDOWN_FE_BOUND.ALL */
>> +	FIXED_EVENT_CONSTRAINT(0x02c2, 6), /* TOPDOWN_RETIRING.ALL */
>> +	INTEL_UEVENT_CONSTRAINT(0x01b7, 0x1),
>> +	INTEL_UEVENT_CONSTRAINT(0x02b7, 0x2),
>> +	INTEL_UEVENT_CONSTRAINT(0x04b7, 0x4),
>> +	INTEL_UEVENT_CONSTRAINT(0x08b7, 0x8),
> Should be these?
>
> INTEL_UEVENT_CONSTRAINT(0x03b7, 0x4),
> INTEL_UEVENT_CONSTRAINT(0x04b7, 0x8),

No, it's a bit mask. Each bit of bits[3:0] corresponds an OMR extra MSR.
Just found there are conflicts about the ARW OMR events umask in ISE.

The table 16-2 "OMR Events Supported by Arctic Wolf Microarchitecture"
indicates the umask of these 4 OMR events are 0x1/0x2/0x4/0x8, but the
umask of OMR events in table 16-9 "Event Counter Restrictions for Arctic
Wolf Microarchitecture" are described to 0x1/0x2/0x3/0x4. I believe the
umasks described in table 16-2 are correct and it's a typo in table 16-9.

I would double check with PME team and let them update the ISE. Thanks.


>