From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Results of my work on memorystick subsystem
Date: Thu, 14 Oct 2010 01:00:33 -0700 (PDT) [thread overview]
Message-ID: <8497.77981.qm@web37601.mail.mud.yahoo.com> (raw)
In-Reply-To: <1287016805-5175-1-git-send-email-maximlevitsky@gmail.com>
> From: Maxim Levitsky <maximlevitsky@gmail.com>
>
> and patch #6 contines adds even more cleanups, and makes
> whole
> memctick subsystem look nice and clean.
> Many non obivous functions were removen.
Replacing functional state handlers with nasty 3-page long switches on
undiscriminated integer state variables does not count either "cleaner"
nor "more obvious" in my notebook.
This is a matter of personal preference, I suppose.
Yet, at the very least, you should define an appropriate enum and give
your states readable names.
next prev parent reply other threads:[~2010-10-14 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 0:39 Results of my work on memorystick subsystem Maxim Levitsky
2010-10-14 0:40 ` [PATCH 1/6] memstick: core: add series of common helpers Maxim Levitsky
2010-10-14 0:40 ` [PATCH 2/6] memstick: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-10-14 0:40 ` [PATCH 3/6] memstick: jmb38x: Driver rework Maxim Levitsky
2010-10-14 0:40 ` [PATCH 4/6] memstick: add support for legacy memorysticks Maxim Levitsky
2010-10-14 0:40 ` [PATCH 5/6] memstick: mspro_block: refactoring Maxim Levitsky
2010-10-14 0:40 ` [PATCH 6/6] memstick: stop passing useless pointer to card->current_mrq + refactoring Maxim Levitsky
2010-10-14 8:00 ` Alex Dubov [this message]
2010-10-14 21:01 ` Results of my work on memorystick subsystem Maxim Levitsky
2010-10-15 6:45 ` Alex Dubov
2010-10-15 13:34 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8497.77981.qm@web37601.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox