From: "Maxime Ripard" <mripard@kernel.org>
To: "Douglas Anderson" <dianders@chromium.org>
Cc: airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, emma@anholt.net,
linux-kernel@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [RFT PATCH 3/6] drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time
Date: Mon, 04 Sep 2023 07:58:54 +0000 [thread overview]
Message-ID: <84acd2a9724fd45a5dff355b3b699b49.mripard@kernel.org> (raw)
In-Reply-To: <20230901163944.RFT.3.I10dbe099fb1059d304ba847d19fc45054f7ffe9f@changeid>
On Fri, 1 Sep 2023 16:39:54 -0700, Douglas Anderson wrote:
> Based on grepping through the source code these drivers appear to be
> missing a call to drm_atomic_helper_shutdown() at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
>
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-09-04 7:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 23:39 [RFT PATCH 0/6] drm: drm-misc drivers call drm_atomic_helper_shutdown() at the right times Douglas Anderson
2023-09-01 23:39 ` [RFT PATCH 1/6] drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a noop Douglas Anderson
2023-09-04 7:55 ` Maxime Ripard
2023-09-05 21:14 ` Doug Anderson
2023-09-13 18:19 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers Douglas Anderson
2023-09-04 7:58 ` Maxime Ripard
2023-09-05 21:06 ` Jernej Škrabec
2023-09-15 9:11 ` suijingfeng
2023-09-15 13:44 ` Doug Anderson
2023-09-15 14:02 ` suijingfeng
2023-09-19 7:31 ` Tomi Valkeinen
2023-09-21 18:46 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 3/6] drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time Douglas Anderson
2023-09-04 7:58 ` Maxime Ripard [this message]
2023-09-21 18:46 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 4/6] drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time Douglas Anderson
2023-09-04 7:59 ` Maxime Ripard
2023-09-21 18:47 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 5/6] drm: Call drm_atomic_helper_shutdown() at shutdown/remove time for misc drivers Douglas Anderson
2023-09-04 8:00 ` Maxime Ripard
2023-09-19 7:09 ` Tomi Valkeinen
2023-09-21 18:48 ` Doug Anderson
2023-09-01 23:39 ` [RFT PATCH 6/6] drm/hisilicon/kirin: Call drm_atomic_helper_shutdown() at shutdown/unbind time Douglas Anderson
2023-09-04 8:00 ` Maxime Ripard
2023-09-21 18:48 ` Doug Anderson
2023-09-13 18:31 ` [RFT PATCH 0/6] drm: drm-misc drivers call drm_atomic_helper_shutdown() at the right times Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84acd2a9724fd45a5dff355b3b699b49.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox