From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 3/6] dt-bindings: codecs: sophgo,cv1800b: codecs: add ADC/DAC
Date: Tue, 20 Jan 2026 16:35:16 +0100 [thread overview]
Message-ID: <84b053b9-d62f-4ab6-b1e7-879bac9a05f7@kernel.org> (raw)
In-Reply-To: <aW-TRX8Bv60Aq-W-@anton.local>
On 20/01/2026 15:43, Anton D. Stavinskii wrote:
> On Tue, Jan 20, 2026 at 11:12:23AM +0400, Krzysztof Kozlowski wrote:
>> On Mon, Jan 19, 2026 at 08:30:44PM +0400, Anton D. Stavinskii wrote:
>>> Document the internal ADC and DAC audio codecs integrated
>>> in the Sophgo CV1800B SoC.
>>>
>>> Signed-off-by: Anton D. Stavinskii <stavinsky@gmail.com>
>>> ---
>>> .../bindings/sound/sophgo,cv1800b-sound-adc.yaml | 43 ++++++++++++++++++++++
>>> .../bindings/sound/sophgo,cv1800b-sound-dac.yaml | 43 ++++++++++++++++++++++
>>
>> This is not what I asked. I did not say squash patches. I asked to
>> squash into the binding. COMBINE the bindings. We do not need multiple
>> documents.
>
> Oh that makes much more sense. Thanks. Will do. You mean single file for
> both codecs. Combined description and "compatible" like this?
> properties:
> compatible:
> enum:
> - sophgo,cv1800b-sound-adc
> - sophgo,cv1800b-sound-dac
> everything else seems to be identical.
Yes.
>
> Can I keep single commit for this?
Yes, single commit adding one binding file for these two devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-20 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 16:30 [PATCH v3 0/6] ASoC: sophgo: add CV1800 I2S controllers support Anton D. Stavinskii
2026-01-19 16:30 ` [PATCH v3 1/6] ASoC: dt-bindings: sophgo,cv1800b: add I2S/TDM controller Anton D. Stavinskii
2026-01-20 10:10 ` Krzysztof Kozlowski
2026-01-19 16:30 ` [PATCH v3 2/6] ASoC: sophgo: add CV1800B I2S/TDM controller driver Anton D. Stavinskii
2026-01-19 16:30 ` [PATCH v3 3/6] dt-bindings: codecs: sophgo,cv1800b: codecs: add ADC/DAC Anton D. Stavinskii
2026-01-19 16:36 ` Mark Brown
2026-01-19 16:42 ` Anton D. Stavinskii
2026-01-20 10:12 ` Krzysztof Kozlowski
2026-01-20 14:43 ` Anton D. Stavinskii
2026-01-20 15:35 ` Krzysztof Kozlowski [this message]
2026-01-19 16:30 ` [PATCH v3 4/6] ASoC: sophgo: add CV1800B internal ADC codec driver Anton D. Stavinskii
2026-01-19 16:30 ` [PATCH v3 5/6] ASoC: sophgo: add CV1800B internal DAC " Anton D. Stavinskii
2026-01-19 16:30 ` [PATCH v3 6/6] riscv: dts: sophgo: dts nodes for i2s tdm modules Anton D. Stavinskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b053b9-d62f-4ab6-b1e7-879bac9a05f7@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=perex@perex.cz \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox