From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 015B370831 for ; Mon, 28 Apr 2025 07:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745824388; cv=none; b=hpdA3QqJyuvSa6iIDKufpqXIg0NyiNBQy4ps8ZgSyRaF+9O7C3nk/nDDJ06vvwGhynZJX5w10ydTmjUrJ5HAM/uas99eTzDS62mecdAxt5IdmloauJiJ3503TgheEpD1G1nFen8AEq1wbUwYLsu97snDs9/8xqMAgJhMnYewAOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745824388; c=relaxed/simple; bh=glvaltJ8AKiRWpSbDKfn8ZwAW9AkVuN9hSA4dCvhEWE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SYaIc72LdFQIvoVbHtCnEAdhALx883u91VmBcOx1qUKB2A24sQtATb2HnxTz0C4/vA4xjsKQGZEHZ9Prh0KOFieKEV0vw4Zp/WOYHPJ9LdzL1vhHNOFGp8AtBQew4QJU3+7tPDaIscov4Krh2vU/WJBAGAqvw6E56M91QhS2jQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BmP7SZb5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BmP7SZb5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745824384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yk38dcNFpb3NyuTUUvlalQvIOAhpTp/gtGWIAYmjz3E=; b=BmP7SZb5PZ1j4W6P1mdh0yOeztaKO4jMPtrEgbjnFZ7VfgZssFjt+J3L0ZDUgJ5nuvGtQ1 Z4L/5E2Dx2ODffJTaBVl2gHcj1sPOneaR7ORRlVJ1jUx10qYLfLq/Nd7TfGbxwo5b610Gd zP/26gmDWzvT10nha2vnkem2AtBIwak= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-1Ktp-TGaN86o4I5DFHdXsQ-1; Mon, 28 Apr 2025 03:13:00 -0400 X-MC-Unique: 1Ktp-TGaN86o4I5DFHdXsQ-1 X-Mimecast-MFC-AGG-ID: 1Ktp-TGaN86o4I5DFHdXsQ_1745824379 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3912a0439afso1135827f8f.3 for ; Mon, 28 Apr 2025 00:13:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745824379; x=1746429179; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yk38dcNFpb3NyuTUUvlalQvIOAhpTp/gtGWIAYmjz3E=; b=kR9O+4LiNfwrOQ5mhyMcgf+DAYcBr0bZeYS36qUGcFvlN/lcDK+Hs5lBHD4FvMuLFu PBx1gSyjwYtRTIL1XSVnUzC92hg/r95lQUY/v0h++N5Ctwcosy2X1VIZ+AnLq8gKMd+O KyKF4JdkzJWCrwiYdkWyXvP5DV/25/A6Xjht9ACi+qxS66isihdJvGkQjg8ZMgjn+KgB 89MqJ5kpMZnNdZOM5681o9IHNt7a4NUvntypMRwLhCthCwl760sxnFuFvSZ69dXsmOmJ Xt9sdEb+kdCiYmPjxlYLYin1PvRnuftjSLEd+7FDmS7m04rFoGk8/maoj0ZtXKthyXdI h1aQ== X-Forwarded-Encrypted: i=1; AJvYcCULed27luesBxEHyciETYpY5k7vF4fLwaGdF+aJ7iedrrHz6kZXpmj56Vpa0ktQIGq7Xd07j26Ku58dhLo=@vger.kernel.org X-Gm-Message-State: AOJu0YxRZiJHwHUjuy2m9z+x89l28Qm9u+bkZhaJDKjKISe9exekUm6X UaXa+9B1gLQO1VnOX0Dda9UKVV9qG2i9z6wXHEz3gwukrJz0RiHTpSj3OwtXvjxQN4cUjK75DEk 9W/q226AWfG1mkSTKT7+q6q1vxRdrlZzXGmiy5myTqnGskbL5aA/IFR4ti58qjw== X-Gm-Gg: ASbGncvDOJ1h7dYEJgYAPj7pyq9mFdhvVPFSmVMxR82eqlHu8YpNkzuUlbt/64KRPeS BqI9iooO/U90xHt72Md3zFf4oWECA4eYT78Pb4UjsaUVgTnLV+oa9YJQxX9BT3UE8LNh2LW6/DH yAbqmA3WOOCQPqFbuyuxU79P1boZ+Dkb5oafMHBjDnbf9o/lM3b80K/rGeO8kidb2xM9Ii4WW6v 5X3n3aVQ38HZ6VmVWjucOZcYrs9pSAsVodPDiasLRE+gygSGVNaZx/RX7485sYrNkKj0KTrDz1D WKsPREkNUIBRfGA+lYslN7JDwRkSq6L+ACUq/j91xW0cho3KEU3QYLQhADGT30Q9u6WZwUcl317 dfErFLZmvRE+GWDt1wE+SumpP3duYjduYOX7j1rs= X-Received: by 2002:a05:6000:1889:b0:39c:3107:c503 with SMTP id ffacd0b85a97d-3a074e373ebmr8519590f8f.31.1745824379188; Mon, 28 Apr 2025 00:12:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGpSAksKCbJ1VK4JeaLjNhMDHZs48tHAcNCnbpVgtIQST0BGNh5aKTscVsAHj7ABAEjwi32Bw== X-Received: by 2002:a05:6000:1889:b0:39c:3107:c503 with SMTP id ffacd0b85a97d-3a074e373ebmr8519557f8f.31.1745824378747; Mon, 28 Apr 2025 00:12:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c968sm10073483f8f.8.2025.04.28.00.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 00:12:58 -0700 (PDT) Message-ID: <84b46ea0-12a1-469f-921e-2d0fd6dacd0d@redhat.com> Date: Mon, 28 Apr 2025 09:12:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-8-dwmw2@infradead.org> <91CA8854-2E86-4AF3-BAD0-8C47833F59D4@infradead.org> <8fd728cf-bc54-433d-8701-234a67933a97@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.04.25 01:04, David Woodhouse wrote: > On Fri, 2025-04-25 at 22:12 +0200, David Hildenbrand wrote: >> >> In any case, trying to figure out why Lorenzo ran into an issue ... if >> it's nit because of the pageblock, maybe something in for_each_valid_pfn >> with sparsemem is still shaky. > > Yep, I think this was it: > > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -2190,10 +2190,10 @@ static inline unsigned long next_valid_pfn(unsigned long pfn, unsigned long end_ > /* > * Either every PFN within the section (or subsection for VMEMMAP) is > * valid, or none of them are. So there's no point repeating the check > - * for every PFN; only call first_valid_pfn() the first time, and when > - * crossing a (sub)section boundary (i.e. !(pfn & ~PFN_VALID_MASK)). > + * for every PFN; only call first_valid_pfn() again when crossing a > + * (sub)section boundary (i.e. !(pfn & ~PAGE_{SUB,}SECTION_MASK)). > */ > - if (pfn & (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ? > + if (pfn & ~(IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ? > PAGE_SUBSECTION_MASK : PAGE_SECTION_MASK)) LGTM, although we could make way this easier to understand: Something like: unsigned long pfn_mask = PAGE_SECTION_MASK; if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) pfn_mask = PAGE_SUBSECTION_MASK; if (pfn & ~pfn_mask) ... -- Cheers, David / dhildenb