Re: [PATCH v1] media: atomisp: Fix typos in comment

[Philipp Hortmann <philipp.g.hortmann@gmail.com>]

On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
> 
> These changes fix the typos in the comment,
> without affecting the functionality.
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
> ---
>   drivers/staging/media/atomisp/pci/atomisp_v4l2.c                | 2 +-
>   .../media/atomisp/pci/hive_isp_css_common/host/input_system.c   | 2 +-
>   drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c   | 2 +-
>   drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c     | 2 +-
>   drivers/staging/media/atomisp/pci/sh_css_mipi.c                 | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index c9984f1557b0..eb46ba4f4f13 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -55,7 +55,7 @@
>   /* G-Min addition: pull this in from intel_mid_pm.h */
>   #define CSTATE_EXIT_LATENCY_C1  1
>   
> -/* cross componnet debug message flag */
> +/* cross component debug message flag */
>   int dbg_level;
>   module_param(dbg_level, int, 0644);
>   MODULE_PARM_DESC(dbg_level, "debug message level (default:0)");
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8f2f4e8eddd9..c18f62fe66b3 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -406,7 +406,7 @@ input_system_err_t input_system_configuration_reset(void)
>   	config.unallocated_ib_mem_words			 = IB_CAPACITY_IN_WORDS;
>   	//config.acq_allocated_ib_mem_words		 = 0;
>   
> -	// Set the start of the session cofiguration.
> +	// Set the start of the session configuration.
>   	config.session_flags = INPUT_SYSTEM_CFG_FLAG_REQUIRED;
>   
>   	return INPUT_SYSTEM_ERR_NO_ERROR;
> diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> index 7ce2b2d6da11..3bfaf52c5cdd 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> @@ -951,7 +951,7 @@ int ia_css_binary_find(struct ia_css_binary_descr *descr, struct ia_css_binary *
>   	unsigned int i;
>   
>   	assert(descr);
> -	/* MW: used after an error check, may accept NULL, but doubtfull */
> +	/* MW: used after an error check, may accept NULL, but doubtful */
>   	assert(binary);
>   
>   	dev_dbg(atomisp_dev, "ia_css_binary_find() enter: descr=%p, (mode=%d), binary=%p\n",
> diff --git a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> index 2d7fddb114f6..0ab83e1b51b8 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> @@ -362,7 +362,7 @@ void ia_css_frame_free_multiple(unsigned int num_frames,
>   int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,
>   					   const unsigned int buffer_size_bytes)
>   {
> -	/* AM: Body coppied from frame_allocate_with_data(). */
> +	/* AM: Body copied from frame_allocate_with_data(). */
>   	int err;
>   	struct ia_css_frame *me = frame_create(0, 0,
>   					       IA_CSS_FRAME_FORMAT_NUM,/* Not valid format yet */
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index 80f0395cc560..710744ff0b24 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -169,7 +169,7 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
>   	/* ceil(words_per_odd_line/8); mem_word = 32 bytes, 8 words */
>   	mem_words_for_first_line = (words_for_first_line + 7) >> 3;
>   	mem_words_per_even_line  = (words_per_even_line + 7) >> 3;
> -	mem_words_for_EOF        = 1; /* last line consisit of the optional (EOL) and EOF */
> +	mem_words_for_EOF        = 1; /* last line consist of the optional (EOL) and EOF */
>   
>   	mem_words = ((embedded_data_size_words + 7) >> 3) +
>   	mem_words_for_first_line +

Hi Jiaoliang,

I cannot apply your patch:
Applying: media: atomisp: Fix typos in comment
error: patch failed: 
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:951
error: drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c: 
patch does not apply
Patch failed at 0001 media: atomisp: Fix typos in comment

Are you using the right git repo?

git remote show origin
* remote origin
   Fetch URL: 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
...
git branch -a
my branch: staging-testing

Please rebase.

Thanks.

Bye Philipp