Re: [PATCH 31/33] iris: variant: iris: implement the logic to compute bus bandwidth

Dikshita Agarwal
2023-08-14T19:22:37Z

On 7/28/2023 11:39 PM, Konrad Dybcio wrote:
> On 28.07.2023 15:23, Vikash Garodia wrote:
>> From: Dikshita Agarwal <quic_dikshita@quicinc.com>
>>
>> This implements the logic to compute bus bandwidth required by encoder
>> or decoder for a specific usecase. It takes input as various video
>> usecase parameters as configured by clients.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
>> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
>> ---
> [...]
>
>> +/* 100x */
>> +static u32 dpbopb_ubwc30_cr_table_cratio_iris3[7][12] = {
> const?
>
> [...]
>
>> +
>> + llc_enabled_ref_y_rd = (codec_input.status_llc_onoff) ? 1 : 0;
>> + llc_enable_ref_crcb_rd = (codec_input.status_llc_onoff) ? 1 : 0;
>> + /* H265D BSE tlb in LLC will be pored in Kailua */
> ?
>
>> + llc_enabled_bse_tlb = (codec_input.status_llc_onoff) ? 1 : 0;
> "? 1 : 0" is fancy bool conversion (!!x)
>
Hi Konrad,

we will remove this bus calculation logic and move to static bus bandwidth
table in next version so this file will be removed.

Thanks,
Dikshita
> Konrad