From: Dave Hansen <dave.hansen@intel.com>
To: Nadav Amit <nadav.amit@gmail.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Nadav Amit <namit@vmware.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org
Subject: Re: [PATCH] x86/mm/tlb: avoid reading mm_tlb_gen when possible
Date: Mon, 6 Jun 2022 08:29:49 -0700 [thread overview]
Message-ID: <84dc784b-10c9-9ade-7a20-97fe0c32f2ff@intel.com> (raw)
In-Reply-To: <20220322220757.8607-1-namit@vmware.com>
On 3/22/22 15:07, Nadav Amit wrote:
> + if (f->new_tlb_gen <= local_tlb_gen) {
> + /*
> + * We are already up to date in respect to f->new_tlb_gen.
> + * While the core might be still behind mm_tlb_gen, checking
> + * mm_tlb_gen unnecessarily would have negative caching effects
> + * so avoid it.
> + */
> + return;
> + }
> +
Nit: There's at least one "we" in here that needs to get fixed up. I'll
plan to do that when I apply it, but a v2 with that fixed and Peter's
ack added might save me five minutes.
next prev parent reply other threads:[~2022-06-06 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 22:07 [PATCH] x86/mm/tlb: avoid reading mm_tlb_gen when possible Nadav Amit
2022-03-28 10:35 ` Peter Zijlstra
2022-06-06 14:29 ` Nadav Amit
2022-06-06 15:29 ` Dave Hansen [this message]
2022-06-06 16:28 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84dc784b-10c9-9ade-7a20-97fe0c32f2ff@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox