From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2ECEB64D9 for ; Thu, 29 Jun 2023 10:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbjF2K4t (ORCPT ); Thu, 29 Jun 2023 06:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232161AbjF2Kzp (ORCPT ); Thu, 29 Jun 2023 06:55:45 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C488268F for ; Thu, 29 Jun 2023 03:55:32 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b6a675743dso6976361fa.2 for ; Thu, 29 Jun 2023 03:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688036130; x=1690628130; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uR/dK7cnl1TOAv90dRpkTTyWoJWXcXjhVWHMYmmHHe0=; b=r1y1qbZUFPs/jNqQXZH0XiAheiLYuBDah3ATxxVptmzHTlxJj8dBwooas4cthzoTdy WzIt81N5dWa0MyHtFb2+pEI/zfvnIw+m3CrEelDHbsHfsb8IK/BCCX0Mzs7ROIYmaJ6F TL5+5m9ZwdS2nnvNF03NM+fUOnQqDEX4Kxf7U14Kw72zCrG/gu6JOr7tgsvBsLafamOE iugAJfsqUjZ4NjUpiNoiycqa5637iOu0kODUB6zOip+VSbu8IgBx+5CCo0T1CX5Qrlpp ZJhR9+6jPSThdp755+Aqoejnv9IAm8GQGGxuRCEmrR+ochB/0tyJoxL4CPOF+q0Lvyx5 5d+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688036130; x=1690628130; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uR/dK7cnl1TOAv90dRpkTTyWoJWXcXjhVWHMYmmHHe0=; b=KpBUCLW9erf5vZW432O6uGLPR7vCME4cXRmyquwqnWupQTdYJAPFeEWCorZ/DucGHf 2QWC3bT/zumL+X5rYjHPnVHl7VDjLTqeT1w/ibfOi2/tWDvTze4DqWRiUPmLxokNEEUu LKiSBPKhXKz7Yqa33q73MfYygNn0AZXLmAUgsEhz7d9MfH0TYKUywNklH086Mc6hjfCY fZfpgdrKrTRBW95V44Hsvtku9JAJkmUhnI05NTV1CD9X59WMAbBEO891tmZeC0Qgt+5B P4yFyuzqdASi1fVT4fiquGEpoLJ7YT0JebqcmLcQ2ZU/ofvJEFHIasYDfs3ubD3CHvTd Kw3g== X-Gm-Message-State: AC+VfDwFhdKogC8enQDWwrG2P2mMXxMVP3heHW3PhHCt6lmT801Kv0DY 0+qiUrYxHlKT4cGFCzLliDE0Rw== X-Google-Smtp-Source: ACHHUZ5p8UBH7vKbUX3uxCQ+NHRtzhhvbvpOuj87ASCvmdXdOVMcyeDyv3SSYzDcrclrVJPlH3520Q== X-Received: by 2002:a2e:96d0:0:b0:2b6:9e1e:f048 with SMTP id d16-20020a2e96d0000000b002b69e1ef048mr11474428ljj.31.1688036130360; Thu, 29 Jun 2023 03:55:30 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id a12-20020a05651c010c00b002b6a5dfc7f3sm1640778ljb.30.2023.06.29.03.55.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 03:55:29 -0700 (PDT) Message-ID: <84eb1d40-436b-a5b4-a4e3-75a511ad5a90@linaro.org> Date: Thu, 29 Jun 2023 13:55:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock Content-Language: en-GB To: Marijn Suijten , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , Loic Poulain , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> <20230627-sm6125-dpu-v2-12-03e430a2078c@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20230627-sm6125-dpu-v2-12-03e430a2078c@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/2023 23:14, Marijn Suijten wrote: > We have a working RPM XO clock; no other driver except rpmcc should be > parenting directly to the fixed-factor xo_board clock nor should it be > reachable by that global name. Remove the name to that effect, so that > every clock relation is explicitly defined in DTS. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index 722dde560bec..edb03508dba3 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -22,7 +22,6 @@ xo_board: xo-board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <19200000>; > - clock-output-names = "xo_board"; Why? I'd say, leave it. With that fixed: Reviewed-by: Dmitry Baryshkov > }; > > sleep_clk: sleep-clk { > @@ -306,6 +305,8 @@ rpm_requests: rpm-requests { > rpmcc: clock-controller { > compatible = "qcom,rpmcc-sm6125", "qcom,rpmcc"; > #clock-cells = <1>; > + clocks = <&xo_board>; > + clock-names = "xo"; > }; > > rpmpd: power-controller { > @@ -713,7 +714,7 @@ sdhc_1: mmc@4744000 { > > clocks = <&gcc GCC_SDCC1_AHB_CLK>, > <&gcc GCC_SDCC1_APPS_CLK>, > - <&xo_board>; > + <&rpmcc RPM_SMD_XO_CLK_SRC>; > clock-names = "iface", "core", "xo"; > iommus = <&apps_smmu 0x160 0x0>; > > @@ -740,7 +741,7 @@ sdhc_2: mmc@4784000 { > > clocks = <&gcc GCC_SDCC2_AHB_CLK>, > <&gcc GCC_SDCC2_APPS_CLK>, > - <&xo_board>; > + <&rpmcc RPM_SMD_XO_CLK_SRC>; > clock-names = "iface", "core", "xo"; > iommus = <&apps_smmu 0x180 0x0>; > > -- With best wishes Dmitry