From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B532351C1E for ; Tue, 7 Jul 2026 14:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435873; cv=none; b=HnNF767IZ6h91doHU2DWnsKP9saNff9yL9hLN+w3ZHdu2gSfNss9d7t5HfBAIKytKpZF8p6YlJD/ywY4JKNOrbqBD1dcaHjABnpIv/UE/RPRSqWUXZ8rZzOJ4cuygQjbZoxqBL0IkBJLRPOZmSoHG1zL8q51DEn0v48ul/sjCqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435873; c=relaxed/simple; bh=RuEaLadIoZsuJyS6ZmkPuRWYcQxb5NYbj/XZuDX8dGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fqblHJDaU0y8yP43wxW+rQ55e65Tr712xbpnpWXiA/ktyMcKwKDVztWAq/tVi05c1KXzwXb7EEo9WlF7gvsANteOL4oPp8bKQPG2E41O1aLhW7tXKtk4ZB2DpwIfPO9zwc1h3stk7vItLslMfVZrk8JYmIvsnB+SscmWJLt3TSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PlLhrtPo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hBXWQGpN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PlLhrtPo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hBXWQGpN" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C9LkT3740874 for ; Tue, 7 Jul 2026 14:51:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dVQCOXxDOJYdfBM0wH+7s2f+TFisB5ucH9qGVZf6tTY=; b=PlLhrtPoG2XGfQwL 4rgO+c1M5c+royndMjQkIioTQdMavHjNcypq+vUq47rfP+FlmO+bEW92DRQ/6/h+ peu+r4mZroQNbvESHdytzd1uDAjopmuxY/VhQ86ericWxHiCfH/qvVDGm4TR5DiI FyQOCvHWQnPyvIwdYFF0rPgbx6/NO0/MD/KuCg77Yxpy1aEKrkkSR2nI6wXgnl/y VpXwQiJJdJXLNsr3fVbbUxnGcsPjYmuggY+wFekr/9si8wc8W9NSVPaLkuR8AASk mW5dBZsrHR66C/dZc3vaMGrq1DvbgvHINJHqr89lluvdjNT30tGmUhiJbtdiSFAh PORlpQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8v9aa1nb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 14:51:09 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfe3fa93bso56101661cf.2 for ; Tue, 07 Jul 2026 07:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783435869; x=1784040669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dVQCOXxDOJYdfBM0wH+7s2f+TFisB5ucH9qGVZf6tTY=; b=hBXWQGpNMYqQMILMfIOoHmoxMxfjVtFL4tDbuIqcEGDqzJmSQfYUZ+AGuCCCiBpMUT tjKYB0iobIOVCazHCXAFYHh1NVYQydqO/llCQOO8vaShn5gaTn8sb9dNCNg3wBjst56G NMbbUwNWiETT9riqxLT5xgluuRTWqc9P/2ZXE1jgHssqmF8M5n84MEV5a7yievrtLiaO daT+sbCQ+D/5+DPDyH4yab8ben/qSX7OJDei7qUgrMRYFgGggEOGysEECfoNahx1CCn/ oHw9hpz49xIoDIGnzpIJnAGadgG/uCmZjj6YdvAkTOJlSpUkIOm2bjvoxd0Qioo9HlR7 7YMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783435869; x=1784040669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dVQCOXxDOJYdfBM0wH+7s2f+TFisB5ucH9qGVZf6tTY=; b=CqcND5COP5sDG+Ci6wh0icZ7WbouG8SvgF2AGEXsHbj61BtjeaUDqczdvLm3uPiUIU ETwq3zCS+FsaEU/cmC/1YzF6GuMROsTzpFi+pzZk/4/IDJfjudXieABNrk0Sl88xyCsU RbtOq88WN0dRvBCWpUpnB6tqTTGPdeC9iGflDs65mqcYq9Lc+vCkuZ4FHoFqGX3hKXly MftiwgHaFga1fqAX8FnzrwFGJMfG/0UWreAyqUjeBcmiIOALZWQdgM5SBEoHkflQ//2w uGCwaiFRKrNgCKEGQ0X6gqsgMY9JDwCwjXvPLAkZaMYDsPvZNvrLk5p8u+A57T2pcSR1 42bQ== X-Forwarded-Encrypted: i=1; AHgh+RriEnlcEQF6muo6a5kdPntDqC1MukGRNWY4HeIdQok1BNckl2MzDTusJP06h3Q01VGeqi2BtCxBWaFeiAI=@vger.kernel.org X-Gm-Message-State: AOJu0YxkaHZbpFs0XEX0m8pogX9+y0m+7irN/X4dY0Yrx3YYiOp5DNxJ hAP/MLXP5r/K2781enLveTFFu60eC10e0e+8PJD51F9H45z1vI5JWxSJl+Gnci7/bqra0paHma8 qOMla2QceHH+0ZuT7iuYgx7qHCwG4xSXRLQTPqFWY+EjKESiStBmU/N/qXcwz6GUTdMM= X-Gm-Gg: AfdE7cn9UHHSeKIITQSMseQ7tuf2Wg7TGY2BRc+oxUjWMt+ksa/bEo1GF6BfPSXLuJD 7I/ZjWXZNvgdsC1Rrh0U1krP844BSoTModLeO9nDIJSXIdz2CPjMiv0wu5NYRniERKi995WdrpQ VwyrwFm6kfNgfSJwG+yDnLpGpkpkctxnBYhsq1NaBReM6mUol7K3nFQw7qhOrXJOes55KayAff5 orWBX/txowTdTI5SPHZB9eJWxxgmERx+VQ6zuhW4XQqqkoAAS3sFWvjL5l0gsg0AGzsKGbgxzw1 vlcenEq2s3BGREwzEwPGEKF68QTN9eEx74WOMtjJyTsmuLAtFLI6tiR8qLmfPbPAE9NywwJW29k xA8w4gHdygcOWXgyZo9hYoliq1k1OKE0rWOb9WSyAlA4NPt9GZX4/Vnr+WEwugUiuk3MEGB44E8 jj4Fa+Hr4= X-Received: by 2002:ac8:7d51:0:b0:51a:8c9c:7f51 with SMTP id d75a77b69052e-51c748df6e7mr57992381cf.68.1783435868984; Tue, 07 Jul 2026 07:51:08 -0700 (PDT) X-Received: by 2002:ac8:7d51:0:b0:51a:8c9c:7f51 with SMTP id d75a77b69052e-51c748df6e7mr57991801cf.68.1783435868305; Tue, 07 Jul 2026 07:51:08 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15ada05d4dsm156219366b.49.2026.07.07.07.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 07:51:07 -0700 (PDT) Message-ID: <84f593f8-eb28-435f-9458-55aff899dc1a@oss.qualcomm.com> Date: Tue, 7 Jul 2026 17:51:04 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder To: Dmitry Baryshkov Cc: Vladimir Zapolskiy , Atanas Filipov , linux-media@vger.kernel.org, bryan.odonoghue@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> <51a0abf2-2a72-4551-894b-2c2de91ba0c2@linaro.org> <74a5b549-987c-4dac-a1a0-ff81150cd6ab@oss.qualcomm.com> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ZJ6BE-Z7IqwB-9gpSs8TijIY8QanmYwy X-Proofpoint-ORIG-GUID: ZJ6BE-Z7IqwB-9gpSs8TijIY8QanmYwy X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDE0NSBTYWx0ZWRfX+m8r9XCo+mEP tYYlXKSYQ0DLgFHVQWxflsliUWVpQnCMG8H0EW+vONCdcCgWQuMkc15WaraLYzMZQ2ntRYWGsEf Qv7ceuyfnBTs4PibWO4GpyajjcQeNVQ= X-Authority-Analysis: v=2.4 cv=b9yCJNGx c=1 sm=1 tr=0 ts=6a4d125d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=MVBuJk07v-XTMpK2hJIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDE0NSBTYWx0ZWRfX0FOCA9Csv+Vp 3Dy4KDtmKyLRmlU5KI6vNwr/K9JfH5B8bO3ysgK0NwK8WQqVMfTXv6LOesJRcT1YZ69J4q2xef1 LDtsPofNqrApVpBXGNoXkjKOvG5OVC9ORbW9scbnQCBGcqvqS21oFawmvRbb+Zq1JX14M1RCun5 HP/VhMf64K4PENQvhjHkCn6GUmU34YVbOv1OK8pERubOzH49HGVkY8n5IcUXhhDdqQ0Uj6lKj+C YTPWPgtk2aeOQtmvwcFWJtVsSliD1GGN6aHyTyBsuSROUCeb5TEOLi8eIky7PmLWLL6nMenoCMW fCIqHuBVfA3WCRG9Qy+v8vYTHHHCl46/mg4PW9NYKoomMzeb2LUHK5yOSBF3YbygHFLUm3H5X7I yrAO961gUHdR2S2J/G+xpGyfIPoqLG5SWA3K78gWlZJyZAA9N3h7zkH12sd42QMpzu5PLiia2vg iG4YulDHIIjFkPhN8CA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070145 On 7/7/2026 5:47 PM, Dmitry Baryshkov wrote: > On Tue, Jul 07, 2026 at 04:47:07PM +0300, Gjorgji Rosikopulos (Consultant) wrote: >> Hi Dmitry, >> >> On 7/7/2026 4:32 PM, Dmitry Baryshkov wrote: >>> On Tue, Jul 07, 2026 at 04:24:19PM +0300, Gjorgji Rosikopulos (Consultant) wrote: >>>> Hi Vlad, >>>> >>>> On 7/6/2026 10:46 AM, Vladimir Zapolskiy wrote: >>>> >>>>>> >>>>>> +            interconnects = <&gem_noc MASTER_AMPSS_M0 >>>>>> QCOM_ICC_TAG_ACTIVE_ONLY >>>>>> +                             &config_noc SLAVE_CAMERA_CFG >>>>>> QCOM_ICC_TAG_ACTIVE_ONLY>, >>>>>> +                            <&mmss_noc MASTER_CAMNOC_HF >>>>>> QCOM_ICC_TAG_ALWAYS >>>>>> +                             &mc_virt SLAVE_EBI_CH0 >>>>>> QCOM_ICC_TAG_ALWAYS>, >>>>>> +                            <&mmss_noc MASTER_CAMNOC_SF >>>>>> QCOM_ICC_TAG_ALWAYS >>>>>> +                             &mc_virt SLAVE_EBI_CH0 >>>>>> QCOM_ICC_TAG_ALWAYS>; >>>>>> +            interconnect-names = "cpu-cfg", >>>>>> +                                 "hf-mnoc", >>>>>> +                                 "sf-mnoc"; >>>>> >>>>> This is the topic, which may raise a disagreement, but I'll repeat my >>>>> position about the need to remove all "CAMSS bus" specific resources from >>>>> the device node, they are found and should be allocated on parent's side. >>>> >>>> The interconnect has functionality to handle bw requests from different >>>> clients. >>>> >>>> Yes the best will be to have camss interconnect, so jpeg and other hw's to >>>> vote >>>> >>>> on that (actually it is possible in icc framework) but what is the benefit >>>> of moving >>>> >>>> those to camss? Is it not better to create camss icc. I understand >>> >>> Please fix your email client and stop inserting extra empty lines. >> Apologies for that. Some Thunderbird settings were missing on my side, i hope now is fine...> >>>> >>>> you want them to be on parent side. But how to vote on bw? Most of the time >>>> it >>> >>> If the driver actually votes on those, I think, it should be fine. This >>> patchset seemed to add bandwidth voting, but then it dropped all the >>> votes in the last commit. >>> >>>> >>>> depends on the jpeg encoder configuration based on resolution format etc. to >>>> set properly average bw. >>>> >>>> So i dont see how that can be done with not explicit dependency on jpeg with >>>> camss and some exported >>>> >>>> API's which we discussed with Bryan they are preferable. >>> >>> Interconnects should be fine to be referenced here. Especially, if JPEG >>> has its own port to those busses (hint, commit message). >>> >>> As I wrote, I see a bigger issue with the clocks. You need to have some >>> API to vote on them (and then let camss driver aggregate those votes in >>> a platform-specific manner). >> Can we use icc-clk framework to vote on them. I think even today there may be some issues in camss >> for the clock voting. > > Please discuss it with the Camera team, working on the camss > improvements. Thanks we will discuss this topic.>