From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: hdegoede@redhat.com, markgross@kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel/pmt: Ignore uninitialized entries
Date: Thu, 13 Apr 2023 13:13:09 +0300 (EEST) [thread overview]
Message-ID: <84f5952a-b64d-c3c8-d80-b9d59fe1ed40@linux.intel.com> (raw)
In-Reply-To: <20230413012922.1521377-1-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
On Wed, 12 Apr 2023, David E. Box wrote:
> On Intel Xeon, unused PMT regions will have uninitialized discovery headers
> containing all 0xF. Instead of returning an error, just skip the region.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/platform/x86/intel/pmt/telemetry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/x86/intel/pmt/telemetry.c
> index 71cdef42084a..39cbc87cc28a 100644
> --- a/drivers/platform/x86/intel/pmt/telemetry.c
> +++ b/drivers/platform/x86/intel/pmt/telemetry.c
> @@ -78,7 +78,7 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
> * reserved for future use. They have zero size. Do not fail
> * probe for these. Just ignore them.
> */
> - if (header->size == 0)
> + if (header->size == 0 || header->access_type == 0xF)
> return 1;
>
> return 0;
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-04-13 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 1:29 [PATCH] platform/x86/intel/pmt: Ignore uninitialized entries David E. Box
2023-04-13 10:13 ` Ilpo Järvinen [this message]
2023-04-17 10:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f5952a-b64d-c3c8-d80-b9d59fe1ed40@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox