Re: [PATCH next v2 3/4] serial: 8250: Switch to nbcon console

John Ogness
2024-09-18T14:47:15Z

On 2024-09-13, John Ogness <john.ogness@linutronix.de> wrote:
> +/*
> + * irq_work handler to perform modem control. Only triggered via
> + * write_atomic() callback because it may be in a scheduler or NMI
> + * context, unable to wake tasks.
> + */
> +static void modem_status_handler(struct irq_work *iwp)
> +{
> + struct uart_8250_port *up = container_of(iwp, struct uart_8250_port, modem_status_work);
> + struct uart_port *port = &up->port;
> +
> + uart_port_lock(port);
> + serial8250_modem_status(up);
> + uart_port_unlock(port);
> +}

As reported [0] by the kernel test robot, I need to move
modem_status_handler() down into the "#ifdef CONFIG_SERIAL_8250_CONSOLE"
block.

John Ogness

[0] https://lore.kernel.org/oe-kbuild-all/202409140437.EP0Ryw3u-lkp@intel.com