From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>, Donghyeok Choe <d7271.choe@samsung.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org, takakura@valinux.co.jp,
youngmin.nam@samsung.com, hajun.sung@samsung.com,
seungh.jung@samsung.com, jh1012.choi@samsung.com
Subject: Re: [PATCH] printk/panic: Add option allow non panic cpus logging to ringbuffer
Date: Mon, 17 Mar 2025 15:19:17 +0106 [thread overview]
Message-ID: <84senbpwxu.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <Z9gnfSYnX3r0wwci@pathway.suse.cz>
On 2025-03-17, Petr Mladek <pmladek@suse.com> wrote:
>> +#ifdef CONFIG_PRINTK_CALLER
>> +static int __init printk_debug_non_panic_cpus_setup(char *str)
>> +{
>> + printk_debug_non_panic_cpus = true;
>> + pr_info("printk: keep printk all cpu in panic.\n");
>
> I would update the message:
>
> pr_info("printk: allow messages from non-panic CPUs in panic()\n");
Note that every printk message in printk.c is automatically prepended
with "printk: " (see #define pr_fmt(fmt) at the top of printk.c) so
please just use:
pr_info("allow messages from non-panic CPUs in panic()\n");
John Ogness
prev parent reply other threads:[~2025-03-17 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250305044241epcas2p45a526aecf91f33b9ac253f561e909978@epcas2p4.samsung.com>
2025-03-05 4:40 ` [PATCH] printk/panic: Add option allow non panic cpus logging to ringbuffer Donghyeok Choe
2025-03-17 13:45 ` Petr Mladek
2025-03-17 14:13 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84senbpwxu.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=d7271.choe@samsung.com \
--cc=hajun.sung@samsung.com \
--cc=jh1012.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=seungh.jung@samsung.com \
--cc=takakura@valinux.co.jp \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox