From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Borislav Petkov <bp@suse.de>
Cc: Chen Yu <yu.c.chen@intel.com>,
mingo@redhat.com, pavel@ucw.cz, tglx@linutronix.de,
hpa@zytor.com, rui.zhang@intel.com, luto@kernel.org,
linux@horizon.com, dsmythies@telus.net, linux-pm@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
marcin.kaszewski@intel.com
Subject: Re: [PATCH][v5] x86, suspend: Save/restore extra MSR registers for suspend
Date: Mon, 12 Oct 2015 21:15:44 +0200 [thread overview]
Message-ID: <8500000.DY8G18orHR@vostro.rjw.lan> (raw)
In-Reply-To: <20151012163750.GA4539@pd.tnic>
On Monday, October 12, 2015 06:37:50 PM Borislav Petkov wrote:
> On Sun, Oct 11, 2015 at 11:20:01AM +0800, Chen Yu wrote:
> > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208)
>
> I get:
>
> "You are not authorized to access bug #1227208.
>
> Most likely the bug has been restricted for internal development
> processes and we cannot grant access."
>
> > that, after resumed from S3, CPU is running at a low speed.
> > After investigation, it is found that, BIOS has modified the value
> > of THERM_CONTROL register during S3, and changes it from 0 to 0x10
> > (thus changes the clock modulation from reserved to enabled),
> > since value of 0x10 means CPU can only get 25% of the Duty Cycle,
> > this triggers the problem.
>
> Is this what the bug described above is? In any case, please remove the
> private bugzilla link and describe the bug in text here.
>
> Also, from reading the other thread about the v4 patch, it sounds like
> intel_pstate can't handle the clock modulation properly, according to
> what Doug says.
>
> So let's have this aspect sorted out properly first please before adding
> yet another ugly BIOS workaround.
>
> Btw, why can't that BIOS be fixed instead?
Because it's been shipped to users.
Thanks,
Rafael
next prev parent reply other threads:[~2015-10-12 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 3:20 [PATCH][v5] x86, suspend: Save/restore extra MSR registers for suspend Chen Yu
2015-10-12 16:37 ` Borislav Petkov
2015-10-12 19:15 ` Rafael J. Wysocki [this message]
2015-10-14 17:41 ` Chen, Yu C
2015-11-16 15:20 ` Chen, Yu C
2015-10-12 19:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8500000.DY8G18orHR@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bp@suse.de \
--cc=dsmythies@telus.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@horizon.com \
--cc=luto@kernel.org \
--cc=marcin.kaszewski@intel.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox