From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6985D313260 for ; Mon, 1 Dec 2025 13:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764594952; cv=none; b=K/H/t5Iz9l3/QD4QtuMVD7hJOIHPA5+/l3Wm55I99WSHKxYcp86NVqjNu1oscUltRN+OJ7AZl/bZWlPNCeF1fp54G56TDiurEW+2i04G6AxkXPTk5wWKliTiqlEu2WCgfKIFuChKe1B21RVSlB8cjcsTrtEv1X0VidhM3f9vhbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764594952; c=relaxed/simple; bh=nbo9Gy1z9me7RbbbLnOg4ADpNmVnEU8hm0G2ysDXIWU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EubDIz4vpvJQDN905PMDp4Sw+bzT1EnXzUmOzGyUCkUCxA+rlIrl3wJYR6jkVHICE8t1ZbgsBQ6gJ8LiJqBWQfquDmR9h9o/GnIFXII2FX61SioO4rU0Q94n3Y2m48RAZxZ7qIZmxr7tZ/og7Ue7MxW0FexWy7ustqCQOIE06d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZcyfNaYE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MvS5ZkIG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZcyfNaYE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MvS5ZkIG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B19MBi83361634 for ; Mon, 1 Dec 2025 13:15:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KO6UX3gdfdkT2yMHnnC93Nu+wZWbIHdz6+QscTqB5gE=; b=ZcyfNaYE3hsYKWhy MjTAZJIxEM2TybhgAE05GpjxkfRiBf77qzbGyC88uK4tY6zjfTtxTjW5+PJALtbl 6PZ9Wk/G19i0HJclMgzxFvyOTugwfHKOAoU/cAvjaKRkNYtVzjHen95AmaURrcUn 0iFL9GuGtAhCGMxZX9POJuzGZ9yKAnRwWqxhpbcqm/sgarTjvECBsh9pNb44kjQO 37mPAS3/nGeaOZwyBdGB5zYP4KLuqWS96nTZKLrzdNE+/+U6C07GE4/9eaw9Ihpq lA8P6RMKG1tMXHyT0Cw+S3qgeFets7YwkTIPh0UfJ2FNd8VZcrHdM+dq7WMdaaOg eSkABA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4as8b00n1r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 13:15:48 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee07f794fcso8142581cf.2 for ; Mon, 01 Dec 2025 05:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764594948; x=1765199748; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KO6UX3gdfdkT2yMHnnC93Nu+wZWbIHdz6+QscTqB5gE=; b=MvS5ZkIGCxhz802jj6+PT9Jo26BpXyOcom97k/i+NUG5jV98UlCjdIgkbXrgmE6JVy XDZBWkEKixNWwdg66FNhRyjAPsSCg2i24q5T5qe7TkbT0Axk/MeUDxdPatTA7TalapPx I4eB+/M4yCh4KKJNcCbC2XJ6DsrFb2jy2mLILzPkLnmnOKvMN4tJVTeWHNut9YuH5L2f VRr5gnJCokQNYZCdRCuu7v5lZod096E8sbhzaWlTZFBPUhMa0xyAoKXvXbg0WPPkkuA9 4sCYgOIe7Kq/WStWMfp4c1iji+JIdOVviRxSl+f73G3fOgjLAxVCikLYTmi2HTEKlJ0w 2v9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764594948; x=1765199748; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KO6UX3gdfdkT2yMHnnC93Nu+wZWbIHdz6+QscTqB5gE=; b=i/LIMBJU1zsdIopCFx/fgp/cwaC/iHAHX7ckN5GEi/rgTtifwu8olbzQfwg7CQIv72 gQzhM2iuSJIkOEcgDEt5yhkuf1HLI5Rpxs+VJUYDIbZM4yRNSsI/xaMDHe0DY9Mjy1pV ZSdykU5W1hUI8AZFDzZdxKTq/CXMTiIFPiUwbmhZr/AZWWjXi6JbpoTbvXUu4X60MOQw aLKp31oS3BmRigMBoq/MhIohX+DA+1eaxJbCUGPDwXbj+n2/nLW+zuHTBW7xW3yoXPYM oKHrvOKzb5dQcK6FDsnInaz83rc8u1sdIjL1EZrc+tJ5T31kzLuCgC/YOas8AiUedyFs u1Pg== X-Forwarded-Encrypted: i=1; AJvYcCVa6pSx2Eau59iBCt7AXuwKQvi2KODxjUPGHo6DmzGkRSAXYn/5IAG+py4NFVW1Zr9hLfdrNMB56HSeRwQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxga0oAikkSA9TdnjxUnr3M5jsI3si5swv8dsvzaN7i+eKnnXya t4tUgDJOL1I/ijOx+spjNP6Pqd0waSNsOL5qXmoM3/4aJOVTOxCcmSns5W9JirJrTll6c0G/DNZ 19op1goVv6JlhJ5KOI827vrTsVy50hLCG/8JBXO7mMWw+0WuFVML8zGYqtwX/d+MIT7o= X-Gm-Gg: ASbGncsM1YjtFwnk74uAVbHnnj9476cZeTeFu2BPP/rd0GVERUBtX1rBtD6adAehj6b HTzNE3znQ89Nj1kh5e5ltLHiiIMpI247ZgCFDc4m7kdWKH+KXP9yzt3Nsq04ffwTHDXXOUyHnqK sbuy5G8aQLnTU00fvsly6WIqIq0DrBmP9poL6ZzyTpZpRs2+mR6RqXAyxWghvh7B+K1xjaUjSZo pB2j7RkukbRezaW1n8Yh+UOs7kTYjXRemFh/RNZ4Taye4syw+ckRfysthmvGW9nM+PgUTNdg1A9 wDBhCTKXE2F/peO1FO+SBiC1kTlW0/JZlHHRnbvN8MsoqkDKSpi6TSXi6nma2imloWCpcWFYQzE a97shE3nIAKpgJV5eDfNOD7F8I3etHkEhL+povP807QJBRk52oUkELmooZmjtWq/SDBM= X-Received: by 2002:ac8:5a46:0:b0:4e8:a54d:cce8 with SMTP id d75a77b69052e-4ee5885ba39mr390589331cf.4.1764594947299; Mon, 01 Dec 2025 05:15:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsc43YZ5vfth/ieBcfBTnzwxswN44JaEXdbd0f7CPZ1tdQd9HPE6e1lDuQM4FJ+9etruHieg== X-Received: by 2002:ac8:5a46:0:b0:4e8:a54d:cce8 with SMTP id d75a77b69052e-4ee5885ba39mr390587631cf.4.1764594945691; Mon, 01 Dec 2025 05:15:45 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751035b75sm13559964a12.20.2025.12.01.05.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 05:15:44 -0800 (PST) Message-ID: <850c172d-66e0-4d28-903d-fbcef7ad7444@oss.qualcomm.com> Date: Mon, 1 Dec 2025 14:15:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] clk: qcom: Add support for VideoCC driver for Kaanapali To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Vladimir Zapolskiy , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20251125-kaanapali-mmcc-v2-v2-0-fb44e78f300b@oss.qualcomm.com> <20251125-kaanapali-mmcc-v2-v2-10-fb44e78f300b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251125-kaanapali-mmcc-v2-v2-10-fb44e78f300b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TcKbdBQh c=1 sm=1 tr=0 ts=692d9505 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=1utaWbyG55iW8k7krG4A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: xlM703J-ses8qe4S3QvlM9HOxoxiFFA2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEwOCBTYWx0ZWRfX5UCfTLYXAUT5 A98lx+mjNZuIRc6YAgsHp9TgI6pl+TXjEcLJHa0A/5WKGChGqWR7GL2x+O+gTRns72i4i0TmsXQ ZMN3vabvuN/JW0lP1G7NaRJFGiVwVei8QXeXS4P6JdTwDAy0jhE24aJS60GfZFWvj7GRJ31g2VM jhs1BcX2a0xmE4dsPpHvcMKKh7JuksliPaYY6cVju7K1rNr3YpQRofdP0cgdz/4QZ0w8iUcp+P9 tCbRE+RnMUc12eIMlQ/CW9FAuwQTlMZUtnodbc9RFj5ZOoAk7mTELyakjAiLlrlmOAm/FYgiGEg voZUyj6tYviZ1/4c/SAwukYRwSak+XcHG/byPjrZRowZD+Pi4q8Yp2D0xMHzchoN+NYG59TX6Ky 5hgCsZqL3XoDUHVLJADzeMyKSHQFpA== X-Proofpoint-GUID: xlM703J-ses8qe4S3QvlM9HOxoxiFFA2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010108 On 11/25/25 6:45 PM, Taniya Das wrote: > Enable Kaanapali video clock driver for video SW to be able to control > the clocks from the Video SW driver. > > Signed-off-by: Taniya Das > --- [...] > +static struct clk_mem_branch video_cc_mvs0_freerun_clk = { > + .mem_enable_reg = 0x80E4, > + .mem_ack_reg = 0x80E4, hex must be lowercase > + .mem_enable_mask = BIT(3), > + .mem_enable_ack_mask = 0xc00, GENMASK(11, 10) > + .mem_enable_invert = true, > + .branch = { > + .halt_reg = 0x80e0, > + .halt_check = BRANCH_HALT, > + .clkr = { > + .enable_reg = 0x80e0, > + .enable_mask = BIT(0), > + .hw.init = &(const struct clk_init_data) { > + .name = "video_cc_mvs0_freerun_clk", > + .parent_hws = (const struct clk_hw*[]) { > + &video_cc_mvs0_clk_src.clkr.hw, > + }, > + .num_parents = 1, > + .flags = CLK_SET_RATE_PARENT, > + .ops = &clk_branch2_ops, > + }, The indentation is a little malformed > +static void clk_kaanapali_regs_configure(struct device *dev, struct regmap *regmap) > +{ > + /* > + * Enable clk_on sync for MVS0 and VPP clocks via VIDEO_CC_SPARE1 > + * during core reset by default. > + */ > + regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0)); regmap_set_bits() lgtm otherwise Konrad