From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752823AbdKHQ32 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 11:29:28 -0500
Received: from mailout.easymail.ca ([64.68.200.34]:49361 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752260AbdKHQ31 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 11:29:27 -0500
Reply-To: shuah@kernel.org
Subject: Re: [PATCH 1/2] selftests: firmware: skip unsupported async loading
 tests
To: Amit Pundir <amit.pundir@linaro.org>,
        kselftest <linux-kselftest@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Luis R . Rodriguez" <mcgrof@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Shuah Khan <shuahkh@osg.samsung.com>, Shuah Khan <shuah@kernel.org>
References: <1510141660-31612-1-git-send-email-amit.pundir@linaro.org>
 <1510141660-31612-2-git-send-email-amit.pundir@linaro.org>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <85203891-7a4e-5a86-d401-5df36bd4db4b@kernel.org>
Date: Wed, 8 Nov 2017 09:29:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1510141660-31612-2-git-send-email-amit.pundir@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/08/2017 04:47 AM, Amit Pundir wrote:
> Ignore async firmware loading tests on older kernel releases,
> which do not support this feature.
> 
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
> ---
>  tools/testing/selftests/firmware/fw_filesystem.sh | 34 ++++++++++++++---------
>  1 file changed, 21 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> index 62f2d6f54929..b1f20fef36c7 100755
> --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> @@ -70,9 +70,13 @@ if printf '\000' >"$DIR"/trigger_request 2> /dev/null; then
>  	exit 1
>  fi
>  
> -if printf '\000' >"$DIR"/trigger_async_request 2> /dev/null; then
> -	echo "$0: empty filename should not succeed (async)" >&2
> -	exit 1
> +if [ ! -e "$DIR"/trigger_async_request ]; then
> +	echo "$0: empty filename: async trigger not supported" >&2
> +else
> +	if printf '\000' >"$DIR"/trigger_async_request 2> /dev/null; then
> +		echo "$0: empty filename should not succeed (async)" >&2
> +		exit 1
> +	fi
>  fi
>  
>  # Request a firmware that doesn't exist, it should fail.
> @@ -105,17 +109,21 @@ else
>  fi
>  
>  # Try the asynchronous version too
> -if ! echo -n "$NAME" >"$DIR"/trigger_async_request ; then
> -	echo "$0: could not trigger async request" >&2
> -	exit 1
> -fi
> -
> -# Verify the contents are what we expect.
> -if ! diff -q "$FW" /dev/test_firmware >/dev/null ; then
> -	echo "$0: firmware was not loaded (async)" >&2
> -	exit 1
> +if [ ! -e "$DIR"/trigger_async_request ]; then
> +	echo "$0: firmware loading: async trigger not supported" >&2

Please make this message consistent with the rest when a test is ignored
as in the following tomake it clear what is being done.

fw_fallback.sh:	echo "usermode helper disabled so ignoring test"
fw_filesystem.sh:		echo "Configuration triggers not present, ignoring test"


thanks,
-- Shuah