From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <mripard@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jyri Sarha <jyri.sarha@iki.fi>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Devarsh Thakkar <devarsht@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/29] drm/tidss: Remove ftrace-like logs
Date: Tue, 2 Sep 2025 15:50:33 +0200 [thread overview]
Message-ID: <8527ee39-6933-4d2f-b834-af628bbadd22@suse.de> (raw)
In-Reply-To: <20250902-drm-state-readout-v1-19-14ad5315da3f@kernel.org>
Am 02.09.25 um 10:32 schrieb Maxime Ripard:
> These logs don't really log any information and create checkpatch
> warnings. Remove them.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Most of this output should be available from DRM's atomic helpers already.
> ---
> drivers/gpu/drm/tidss/tidss_crtc.c | 6 ------
> drivers/gpu/drm/tidss/tidss_dispc.c | 4 ----
> drivers/gpu/drm/tidss/tidss_drv.c | 16 ----------------
> drivers/gpu/drm/tidss/tidss_kms.c | 4 ----
> drivers/gpu/drm/tidss/tidss_plane.c | 8 --------
> 5 files changed, 38 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c
> index f497138ad053ed4be207e12eeee6c304e1c949bd..091f82c86f53bc76c572de4723746af2e35ce1c1 100644
> --- a/drivers/gpu/drm/tidss/tidss_crtc.c
> +++ b/drivers/gpu/drm/tidss/tidss_crtc.c
> @@ -92,12 +92,10 @@ static int tidss_crtc_atomic_check(struct drm_crtc *crtc,
> struct tidss_crtc *tcrtc = to_tidss_crtc(crtc);
> u32 hw_videoport = tcrtc->hw_videoport;
> struct drm_display_mode *mode;
> enum drm_mode_status ok;
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> if (!crtc_state->enable)
> return 0;
>
> mode = &crtc_state->adjusted_mode;
>
> @@ -326,12 +324,10 @@ static const struct drm_crtc_helper_funcs tidss_crtc_helper_funcs = {
> static int tidss_crtc_enable_vblank(struct drm_crtc *crtc)
> {
> struct drm_device *ddev = crtc->dev;
> struct tidss_device *tidss = to_tidss(ddev);
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> tidss_runtime_get(tidss);
>
> tidss_irq_enable_vblank(crtc);
>
> return 0;
> @@ -340,12 +336,10 @@ static int tidss_crtc_enable_vblank(struct drm_crtc *crtc)
> static void tidss_crtc_disable_vblank(struct drm_crtc *crtc)
> {
> struct drm_device *ddev = crtc->dev;
> struct tidss_device *tidss = to_tidss(ddev);
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> tidss_irq_disable_vblank(crtc);
>
> tidss_runtime_put(tidss);
> }
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index 8b1d6b72f303b91fbf86f7d0e351800804757126..7d94c1142e8083dab00fcf5c652ae40f98baeabf 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -2863,12 +2863,10 @@ int dispc_runtime_resume(struct dispc_device *dispc)
> return 0;
> }
>
> void dispc_remove(struct tidss_device *tidss)
> {
> - dev_dbg(tidss->dev, "%s\n", __func__);
> -
> tidss->dispc = NULL;
> }
>
> static int dispc_iomap_resource(struct platform_device *pdev, const char *name,
> void __iomem **base)
> @@ -3006,12 +3004,10 @@ int dispc_init(struct tidss_device *tidss)
> struct dispc_device *dispc;
> const struct dispc_features *feat;
> unsigned int i, num_fourccs;
> int r = 0;
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> feat = tidss->feat;
>
> if (feat->subrev != DISPC_K2G) {
> r = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48));
> if (r)
> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index 27d9a8fd541fc164f2fb2535f148432bd7895f46..1c8cc18bc53c3ea3c50368b9f55ab02a0a02fc77 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -31,45 +31,37 @@
>
> int tidss_runtime_get(struct tidss_device *tidss)
> {
> int r;
>
> - dev_dbg(tidss->dev, "%s\n", __func__);
> -
> r = pm_runtime_resume_and_get(tidss->dev);
> WARN_ON(r < 0);
> return r;
> }
>
> void tidss_runtime_put(struct tidss_device *tidss)
> {
> int r;
>
> - dev_dbg(tidss->dev, "%s\n", __func__);
> -
> pm_runtime_mark_last_busy(tidss->dev);
>
> r = pm_runtime_put_autosuspend(tidss->dev);
> WARN_ON(r < 0);
> }
>
> static int __maybe_unused tidss_pm_runtime_suspend(struct device *dev)
> {
> struct tidss_device *tidss = dev_get_drvdata(dev);
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> return dispc_runtime_suspend(tidss->dispc);
> }
>
> static int __maybe_unused tidss_pm_runtime_resume(struct device *dev)
> {
> struct tidss_device *tidss = dev_get_drvdata(dev);
> int r;
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> r = dispc_runtime_resume(tidss->dispc);
> if (r)
> return r;
>
> return 0;
> @@ -77,21 +69,17 @@ static int __maybe_unused tidss_pm_runtime_resume(struct device *dev)
>
> static int __maybe_unused tidss_suspend(struct device *dev)
> {
> struct tidss_device *tidss = dev_get_drvdata(dev);
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> return drm_mode_config_helper_suspend(&tidss->ddev);
> }
>
> static int __maybe_unused tidss_resume(struct device *dev)
> {
> struct tidss_device *tidss = dev_get_drvdata(dev);
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> return drm_mode_config_helper_resume(&tidss->ddev);
> }
>
> static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
> @@ -125,12 +113,10 @@ static int tidss_probe(struct platform_device *pdev)
> struct tidss_device *tidss;
> struct drm_device *ddev;
> int ret;
> int irq;
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> tidss = devm_drm_dev_alloc(&pdev->dev, &tidss_driver,
> struct tidss_device, ddev);
> if (IS_ERR(tidss))
> return PTR_ERR(tidss);
>
> @@ -226,12 +212,10 @@ static void tidss_remove(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct tidss_device *tidss = platform_get_drvdata(pdev);
> struct drm_device *ddev = &tidss->ddev;
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> drm_dev_unregister(ddev);
>
> drm_atomic_helper_shutdown(ddev);
>
> tidss_irq_uninstall(ddev);
> diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
> index c34eb90cddbeac634f281cf163d493ba75b7ea29..86eb5d97410bedced57129c2bbcd35f1719424c2 100644
> --- a/drivers/gpu/drm/tidss/tidss_kms.c
> +++ b/drivers/gpu/drm/tidss/tidss_kms.c
> @@ -22,12 +22,10 @@
> static void tidss_atomic_commit_tail(struct drm_atomic_state *old_state)
> {
> struct drm_device *ddev = old_state->dev;
> struct tidss_device *tidss = to_tidss(ddev);
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> tidss_runtime_get(tidss);
>
> drm_atomic_helper_commit_modeset_disables(ddev, old_state);
> drm_atomic_helper_commit_planes(ddev, old_state, DRM_PLANE_COMMIT_ACTIVE_ONLY);
> drm_atomic_helper_commit_modeset_enables(ddev, old_state);
> @@ -243,12 +241,10 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss)
> int tidss_modeset_init(struct tidss_device *tidss)
> {
> struct drm_device *ddev = &tidss->ddev;
> int ret;
>
> - dev_dbg(tidss->dev, "%s\n", __func__);
> -
> ret = drmm_mode_config_init(ddev);
> if (ret)
> return ret;
>
> ddev->mode_config.min_width = 8;
> diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c
> index 142ae81951a0916ccf7d3add1b83b011eca7f6b9..bd10bc1b9961571e6c6dee26698149fc9dd135b0 100644
> --- a/drivers/gpu/drm/tidss/tidss_plane.c
> +++ b/drivers/gpu/drm/tidss/tidss_plane.c
> @@ -40,12 +40,10 @@ static int tidss_plane_atomic_check(struct drm_plane *plane,
> struct drm_crtc_state *crtc_state;
> u32 hw_plane = tplane->hw_plane_id;
> u32 hw_videoport;
> int ret;
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> if (!new_plane_state->crtc) {
> /*
> * The visible field is not reset by the DRM core but only
> * updated by drm_atomic_helper_check_plane_state(), set it
> * manually.
> @@ -122,12 +120,10 @@ static void tidss_plane_atomic_update(struct drm_plane *plane,
> struct tidss_plane *tplane = to_tidss_plane(plane);
> struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
> plane);
> u32 hw_videoport;
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> if (!new_state->visible) {
> dispc_plane_enable(tidss->dispc, tplane->hw_plane_id, false);
> return;
> }
>
> @@ -141,24 +137,20 @@ static void tidss_plane_atomic_enable(struct drm_plane *plane,
> {
> struct drm_device *ddev = plane->dev;
> struct tidss_device *tidss = to_tidss(ddev);
> struct tidss_plane *tplane = to_tidss_plane(plane);
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> dispc_plane_enable(tidss->dispc, tplane->hw_plane_id, true);
> }
>
> static void tidss_plane_atomic_disable(struct drm_plane *plane,
> struct drm_atomic_state *state)
> {
> struct drm_device *ddev = plane->dev;
> struct tidss_device *tidss = to_tidss(ddev);
> struct tidss_plane *tplane = to_tidss_plane(plane);
>
> - dev_dbg(ddev->dev, "%s\n", __func__);
> -
> dispc_plane_enable(tidss->dispc, tplane->hw_plane_id, false);
> }
>
> static void drm_plane_destroy(struct drm_plane *plane)
> {
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2025-09-02 13:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 8:32 [PATCH 00/29] drm: Implement state readout support Maxime Ripard
2025-09-02 8:32 ` [PATCH 01/29] drm/atomic: Document atomic state lifetime Maxime Ripard
2025-09-02 13:08 ` Thomas Zimmermann
2025-09-02 18:59 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 02/29] drm/atomic: Fix unused but set warning in for_each_old_plane_in_state Maxime Ripard
2025-09-02 13:10 ` Thomas Zimmermann
2025-09-02 19:25 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 03/29] drm/atomic: Fix unused but set warning in for_each_old_private_obj_in_state Maxime Ripard
2025-09-02 13:10 ` Thomas Zimmermann
2025-09-02 19:26 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 04/29] drm/atomic_helper: Skip over NULL private_obj pointers Maxime Ripard
2025-09-02 13:13 ` Thomas Zimmermann
2025-09-02 19:29 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 05/29] drm/atomic_state_helper: Fix bridge state initialization Maxime Ripard
2025-09-02 13:18 ` Thomas Zimmermann
2025-09-02 19:49 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 06/29] drm/bridge: Implement atomic_print_state Maxime Ripard
2025-09-02 13:22 ` Thomas Zimmermann
2025-09-02 20:22 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 07/29] drm/atomic: Implement drm_atomic_print_old_state Maxime Ripard
2025-09-02 13:26 ` Thomas Zimmermann
2025-09-02 20:35 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 08/29] drm/atomic: Only call atomic_destroy_state on a !NULL pointer Maxime Ripard
2025-09-02 13:30 ` Thomas Zimmermann
2025-09-02 20:52 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 09/29] drm/modeset: Create atomic_reset hook Maxime Ripard
2025-09-02 21:04 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 10/29] drm/atomic: Add atomic_state_readout infrastructure Maxime Ripard
2025-09-02 13:44 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 11/29] drm/crtc: Drop no_vblank bit field Maxime Ripard
2025-09-02 13:45 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 12/29] drm/atomic_helper: Pass nonblock to commit_tail Maxime Ripard
2025-09-02 13:46 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 13/29] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2025-09-02 8:32 ` [PATCH 14/29] drm/atomic_state_helper: Provide comparison macros Maxime Ripard
2025-09-02 8:32 ` [PATCH 15/29] drm/atomic_state_helper: Provide atomic_compare_state helpers Maxime Ripard
2025-09-02 8:32 ` [PATCH 16/29] drm/encoder: Create get_current_crtc hook Maxime Ripard
2025-09-02 8:32 ` [PATCH 17/29] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2025-09-02 8:32 ` [PATCH 18/29] drm/tidss: Convert to drm logging Maxime Ripard
2025-09-02 13:49 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 19/29] drm/tidss: Remove ftrace-like logs Maxime Ripard
2025-09-02 13:50 ` Thomas Zimmermann [this message]
2025-09-02 8:32 ` [PATCH 20/29] drm/tidss: crtc: Change variable name Maxime Ripard
2025-09-02 13:51 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 21/29] drm/tidss: crtc: Implement destroy_state Maxime Ripard
2025-09-02 13:52 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 22/29] drm/tidss: crtc: Cleanup reset implementation Maxime Ripard
2025-09-02 13:54 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 23/29] drm/tidss: dispc: Add format lookup by hw value Maxime Ripard
2025-09-02 8:32 ` [PATCH 24/29] drm/tidss: dispc: Improve mode checking logs Maxime Ripard
2025-09-02 14:06 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 25/29] drm/tidss: dispc: Move dispc_device definition to headers Maxime Ripard
2025-09-02 8:32 ` [PATCH 26/29] drm/tidss: dispc: make accessors accessible to other parts of the driver Maxime Ripard
2025-09-02 8:32 ` [PATCH 27/29] drm/tidss: Implement readout support Maxime Ripard
2025-09-02 8:32 ` [PATCH 28/29] drm/tidss: encoder: implement get_current_crtc Maxime Ripard
2025-09-02 8:32 ` [PATCH 29/29] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2025-09-02 14:13 ` [PATCH 00/29] drm: Implement state readout support Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8527ee39-6933-4d2f-b834-af628bbadd22@suse.de \
--to=tzimmermann@suse.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).