From: Paolo Bonzini <pbonzini@redhat.com>
To: Joe Perches <joe@perches.com>,
Stephen Zhang <stephenzhangzsd@gmail.com>,
seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk()
Date: Wed, 27 Jan 2021 19:23:33 +0100 [thread overview]
Message-ID: <854ee6dc-2299-3897-c4af-3f7058f195af@redhat.com> (raw)
In-Reply-To: <cfb3699fc03cff1e4c4ffe3c552dba7b7727fa09.camel@perches.com>
On 27/01/21 18:25, Joe Perches wrote:
>
> -#ifdef MMU_DEBUG
> -bool dbg = 0;
> -module_param(dbg, bool, 0644);
> -#endif
> -
> #define PTE_PREFETCH_NUM 8
>
> #define PT32_LEVEL_BITS 10
> @@ -844,17 +839,17 @@ static int pte_list_add(struct kvm_vcpu *vcpu, u64 *spte,
> int i, count = 0;
>
> if (!rmap_head->val) {
> - rmap_printk("pte_list_add: %p %llx 0->1\n", spte, *spte);
> + pr_debug("%p %llx 0->1\n", spte, *spte);
> rmap_head->val = (unsigned long)spte;
> } else if (!(rmap_head->val & 1)) {
> - rmap_printk("pte_list_add: %p %llx 1->many\n", spte, *spte);
> + pr_debug("%p %llx 1->many\n", spte, *spte);
> desc = mmu_alloc_pte_list_desc(vcpu);
This would be extremely slow. These messages are even too verbose for
tracepoints.
Paolo
next prev parent reply other threads:[~2021-01-27 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 2:08 [PATCH] KVM: x86/mmu: Add '__func__' in rmap_printk() Stephen Zhang
2021-01-27 10:54 ` Paolo Bonzini
2021-01-27 17:25 ` Joe Perches
2021-01-27 18:23 ` Paolo Bonzini [this message]
2021-01-27 18:28 ` Joe Perches
2021-01-28 8:24 ` Paolo Bonzini
2021-02-02 16:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=854ee6dc-2299-3897-c4af-3f7058f195af@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joe@perches.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=stephenzhangzsd@gmail.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox