Re: [PATCH V4 4/4] media: ti: vpe: Add the VIP driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/10/2025 07:19, Krzysztof Kozlowski wrote:
> On 15/10/2025 07:40, Yemike Abhilash Chandra wrote:
>> +static int vip_probe_complete(struct platform_device *pdev)
>> +{
>> +	struct vip_shared *shared = platform_get_drvdata(pdev);
>> +	struct vip_ctrl_module *ctrl = NULL;
>> +	struct vip_port *port;
>> +	struct vip_dev *dev;
>> +	struct device_node *parent = pdev->dev.of_node;
>> +	struct fwnode_handle *ep = NULL;
>> +	struct of_phandle_args args;
>> +	int ret, i, slice_id, port_id, p;
>> +
>> +	/* Allocate ctrl before using it */
>> +	ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL);
>> +	if (!ctrl)
>> +		return -ENOMEM;
>> +
>> +	if (parent && of_property_present(parent, "ti,ctrl-module")) {
>> +		ctrl->syscon_pol = syscon_regmap_lookup_by_phandle(parent,
>> +								   "ti,ctrl-module");
>> +		if (IS_ERR(ctrl->syscon_pol))
>> +			return dev_err_probe(&pdev->dev, PTR_ERR(ctrl->syscon_pol),
>> +				     "Failed to get ti,ctrl-module regmap\n");
>> +	}
>> +
>> +	ret = of_parse_phandle_with_fixed_args(parent, "ti,ctrl-module",
>> +					       5, 0, &args);
> 
> 1. You leak parent.


I meant args->np, obviously.

> 2. Why you can't just just take it from syscon call? This is not only
> leaking, but actually duplicated and unnecessary.
> 
>> +
Best regards,
Krzysztof