From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5144DC2BA18 for ; Mon, 6 Apr 2020 05:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 245122074F for ; Mon, 6 Apr 2020 05:08:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cI1x1u94" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbgDFFIr (ORCPT ); Mon, 6 Apr 2020 01:08:47 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:33211 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgDFFIq (ORCPT ); Mon, 6 Apr 2020 01:08:46 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586149726; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=e9dLjINQKPN1LVIoIlwlnA22th7UlgTMqbgS6SOqu/E=; b=cI1x1u94PhoZGRToYKYHPO6BNjD4t24DSQ1F9UDSkf5Nm/9ASvNi/f5gdWmUWiCP9FZ6PIbQ jNTXOI7T8pcWex2B8pI/vqN3DZFwds0w5uKiCd2nTfJNi3FBIVn40OQSeImTkPgJrHOcR+LS 2ckMR8PwYLQEn7BYat0mwBpqcO4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8ab95d.7f51098a1420-smtp-out-n04; Mon, 06 Apr 2020 05:08:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EBF7DC43636; Mon, 6 Apr 2020 05:08:44 +0000 (UTC) Received: from [192.168.43.137] (unknown [106.213.172.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mkshah) by smtp.codeaurora.org (Postfix) with ESMTPSA id D2CE7C433D2; Mon, 6 Apr 2020 05:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D2CE7C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=mkshah@codeaurora.org Subject: Re: [PATCH v15 6/7] soc: qcom: rpmh-rsc: Clear active mode configuration for wake TCS To: Doug Anderson Cc: Stephen Boyd , Evan Green , Bjorn Andersson , LKML , linux-arm-msm , Andy Gross , Matthias Kaehlcke , Rajendra Nayak , Lina Iyer , lsrao@codeaurora.org, "Raju P.L.S.S.S.N" References: <1585660782-23416-1-git-send-email-mkshah@codeaurora.org> <1585660782-23416-7-git-send-email-mkshah@codeaurora.org> From: Maulik Shah Message-ID: <855bb87e-6c5c-8fee-e237-f48f9d95e2ac@codeaurora.org> Date: Mon, 6 Apr 2020 10:38:36 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/3/2020 1:44 AM, Doug Anderson wrote: > Hi, > > On Tue, Mar 31, 2020 at 6:21 AM Maulik Shah wrote: >> @@ -243,6 +279,14 @@ static irqreturn_t tcs_tx_done(int irq, void *p) >> } >> >> trace_rpmh_tx_done(drv, i, req, err); >> + >> + /* >> + * If wake tcs was re-purposed for sending active >> + * votes, clear AMC trigger & enable modes and >> + * disable interrupt for this TCS >> + */ >> + if (!drv->tcs[ACTIVE_TCS].num_tcs) >> + __tcs_set_trigger(drv, i, false); > Still seems weird that we have to do the untrigger in the IRQ routine > here and also weird that we _don't_ do it in the IRQ routine for > non-borrowed TCSes. I guess it's not the end of the world, though. > > Reviewed-by: Douglas Anderson Thanks Doug for the review. IRQ is only needed to be enabled for TCSes used as ACTIVE_TCS. When we have dedicated ACTIVE_TCS, we leave IRQ always enabled from probe (one time configuration), since the TCS won't be used for anything other than to send ACTIVE transaction. When we don't have dedicated ACTIVE_TCS, we enable it when borrowed TCS is used for ACTIVE transaction and then once its done using it, we disable it again to leave it in its original configuration. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation