From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752300AbcFVOIL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 10:08:11 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:49270 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750970AbcFVOII (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 10:08:08 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, torvalds@linux-foundation.org, tytso@mit.edu,
        viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
        Hiral Patel <hiralpat@cisco.com>, Suma Ramars <sramars@cisco.com>,
        Brian Uchino <buchino@cisco.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        John Stultz <john.stultz@linaro.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps
Date: Wed, 22 Jun 2016 16:09:24 +0200
Message-ID: <8562537.c35I4lEtz8@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1466382443-11063-20-git-send-email-deepa.kernel@gmail.com>
References: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> <1466382443-11063-20-git-send-email-deepa.kernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:6CYUymMgSMYmniVs6TWDs0xUSzI2Fw3QFnNtmrIsUgaxMa5rWru
 hjC/4eKHfdu9U/Fdc08tOpF2BWuYeP6awZ96LyVcx9QjmyX5BAEeD8EOkmfdX9/mD/3DGlh
 NZLHuP8GznCVj565Zz21qgKJIH5Sjbbsp4X+t68ascOtbnnZA7F/qkZWCGeBy2vmDVdrJSA
 uY7M7Vo+/+2ltXEWgnB1g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:l7pejM2Hl6w=:rUeQ7zIAjdjrxK35AcI/fV
 DpdHTJp4ZeeFePXtu0HasqRC1C4iw+XK9hjKTJksEg/CWKOL3ahg1LgoU7P1mzSw+C5f3Gqf/
 8yKa+K0cX9myZ6FAWJPZ3cY/s22r25Shw3kHnRbznfmVd82BIj1FQpWmKJcnr9tCoSP3Tb5Po
 wlNG4gpGctLugzoyWOT2kz9ZX5g583GMJhdHQaRutqvh++jorSReq/UoIjcjiC0O/aSNUMujH
 PLN40m1YTYKqeYXO2jLYYYwyvwNVrqF+cUtQ1tj6IkrIp2ywYxhN4tByGCnspD13nsMvEd1XY
 Nb1MoyuV1yULf+isYIhgo7VAmz4WNH71kXKjC2pX9haWDIy8tK+Q9CFtZ1MLo9zRJ4jMhH/v+
 x1rF14Rzi5GuwKAyEbDBj5Deg8NZehHAI7Ouox0i62tC7T6xbXMdWXPHymmb/AMWM4Ees5uU2
 hAwoKtJdkMzpyjvy9f8CEtTQsPIIaKIbrJDv9VLDvk9xVWTBTNy2nWo2gRgL0PBcGSH9woQBh
 kz/Y/7YfN08sGndiB90/DiwOYH+lRZWEQlb+DgMm88Xnz3hAXhuluxWtiqPn2l5hroEltZ/OE
 MVARpBuozuWTQBbDZUMUK8yjkLhbhzR7L7V9gq++aHo1oj8H+US1IqxHQ9rXDvmggRjKY9Ts5
 nJ8iMc0TIOiNUiG8ie8pXAbT9cI3l/iXG3ucZJJYecasY/wbzYBMSv2e0mm93Mj4Sl9qXKTuu
 JYqwXvUtQG3nYlhp
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, June 19, 2016 5:27:18 PM CEST Deepa Dinamani wrote:
> trace timestamps use struct timespec and CURRENT_TIME which
> are not y2038 safe.
> These timestamps are only part of the trace log on the machine
> and are not shared with the fnic.
> Replace then with y2038 safe struct timespec64 and
> ktime_get_real_ts64(), respectively.
> 
> Note that change to add time64_to_tm() is already part of John's
> kernel tree: https://lkml.org/lkml/2016/6/17/875 .
> 

While the patch looks good, I think it can't be part of this
series now, since it has to go on top of that first patch,
rather than merged in parallel.

When you send a pull request, please leave it out and submit
this one separately after 4.8-rc1.

	Arnd