From: Jens Axboe <axboe@kernel.dk>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCHSET 0/2] Get rid of import_single_range()
Date: Tue, 5 Dec 2023 06:46:58 -0700 [thread overview]
Message-ID: <8562f120-13f2-473c-9024-a4c5996fd5e3@kernel.dk> (raw)
In-Reply-To: <20231205-kaminholz-halstuch-280db992267b@brauner>
On 12/5/23 3:57 AM, Christian Brauner wrote:
> On Mon, Dec 04, 2023 at 10:47:48AM -0700, Jens Axboe wrote:
>> Hi,
>>
>> While looking at this today, I noticed that the 'iov' argument to this
>> function is totally dead code. Patch 1 gets rid of it, and with this
>> function and import_ubuf() now being identical, converts the callers
>> to just use import_ubuf().
>>
>> No functional changes here, just a cleanup removing some dead code.
>
> Looks good. I've picked this up into vfs.iov_iter but let me know if
> you're already carrying this.
That's fine thanks, I don't have them stashed anywhere.
--
Jens Axboe
next prev parent reply other threads:[~2023-12-05 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 17:47 [PATCHSET 0/2] Get rid of import_single_range() Jens Axboe
2023-12-04 17:47 ` [PATCH 1/2] iov_iter: remove unused 'iov' argument from import_single_range() Jens Axboe
2023-12-04 17:47 ` [PATCH 2/2] iov_iter: replace import_single_range() with import_ubuf() Jens Axboe
2023-12-05 10:57 ` [PATCHSET 0/2] Get rid of import_single_range() Christian Brauner
2023-12-05 13:46 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 17:43 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8562f120-13f2-473c-9024-a4c5996fd5e3@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox