Re: [PATCH v16 12/13] x86/tsc: Switch to native sched clock

Nikunj A. Dadhania
2025-01-08T08:35:09Z

On 1/8/2025 1:52 PM, Borislav Petkov wrote:
> On Wed, Jan 08, 2025 at 10:50:13AM +0530, Nikunj A. Dadhania wrote:
> And your patch doesn't have that at all. I know Sean thinks it is a good idea
> and perhaps it is but without proper justification and acks from the other
> guest type maintainers, I simply won't take such a patch(-set).

I haven't heard anything from other guest type maintainers yet, and they are
on CC from v12 onward.

> And even if it is good, you need to solve it another way - not with this
> delayed-work hackery.
>
> IOW, this switching the paravirt clock crap to use TSC when the TSC is this
> and that and the HV tells you so, should be a wholly separate patchset with
> reviews and acks and the usual shebang.

I agree, we should handle this as a separate patch series.

> If you want to take care only of STSC now, I'd take a patch which is known
> good and tested properly. And that should happen very soon because the merge
> window is closing in.

In that case, let me limit this only to STSC for now, i will send updated patch.

Regards,
Nikunj