Re: [PATCH v16 05/13] x86/sev: Add Secure TSC support for SNP guests

Nikunj A. Dadhania
2025-01-07T11:43:15Z

On 1/7/2025 4:12 PM, Borislav Petkov wrote:
> On Mon, Jan 06, 2025 at 06:16:25PM +0530, Nikunj A Dadhania wrote:
>> diff --git a/arch/x86/coco/core.c b/arch/x86/coco/core.c
>> index 0f81f70aca82..715c2c09582f 100644
>> --- a/arch/x86/coco/core.c
>> +++ b/arch/x86/coco/core.c
>> @@ -97,6 +97,10 @@ static bool noinstr amd_cc_platform_has(enum cc_attr attr)
>> case CC_ATTR_GUEST_SEV_SNP:
>> return sev_status & MSR_AMD64_SEV_SNP_ENABLED;
>>
>> + case CC_ATTR_GUEST_SNP_SECURE_TSC:
>> + return (sev_status & MSR_AMD64_SEV_SNP_ENABLED) &&
>
> This is new here?

Yes, this was suggested by Tom here [1]

>> + (sev_status & MSR_AMD64_SNP_SECURE_TSC);
>> +
>

Regards
Nikunj

1. https://lore.kernel.org/all/bad7406d-4a0b-d871-cc02-3ffb9e9185ba@amd.com