Re: [PATCH v16 05/13] x86/sev: Add Secure TSC support for SNP guests

Borislav Petkov
2025-01-07T12:37:42Z

On Tue, Jan 07, 2025 at 05:13:03PM +0530, Nikunj A. Dadhania wrote:
> >> + case CC_ATTR_GUEST_SNP_SECURE_TSC:
> >> + return (sev_status & MSR_AMD64_SEV_SNP_ENABLED) &&
> >
> > This is new here?
>
> Yes, this was suggested by Tom here [1]

Either of you care to explain why this is needed?

> >> + (sev_status & MSR_AMD64_SNP_SECURE_TSC);

I would strongly assume that whatever sets MSR_AMD64_SNP_SECURE_TSC will have
checked/set MSR_AMD64_SEV_SNP_ENABLED already.

--
Regards/Gruss,
Boris.