The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan.gerhold@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Alexey Klimov <alexey.klimov@linaro.org>,
	Anthony Ruhier <aruhier@mailbox.org>,
	Stefan Schmidt <stefan.schmidt@linaro.org>
Subject: Re: [PATCH v2 3/9] arm64: dts: qcom: x1-el2: Disable IRIS for now
Date: Mon, 15 Sep 2025 12:02:31 +0100	[thread overview]
Message-ID: <85b6de36-4f0a-41f4-a803-77355d5da3af@linaro.org> (raw)
In-Reply-To: <20250915-x1e-iris-dt-v2-3-1f928de08fd4@linaro.org>

On 15/09/2025 11:06, Stephan Gerhold wrote:
> The reset and IOMMU management for remoteprocs like IRIS is implemented in
> the hypervisor for older targets such as X1E [1]. When booting Linux/KVM
> directly in EL2, this functionality is missing and the PAS interface
> normally used by IRIS to boot the video firmware is not working.
> 
> The Venus driver supports starting the video firmware without using the PAS
> interface. The same code also works for X1E when using KVM. However, for
> the new IRIS dt-bindings it was decided to avoid using the dummy
> "video-firmware" node in the device tree to describe the IOMMU [2].
> Discussion is still ongoing how to describe this properly [3].
> 
> To avoid regressions when running using KVM, add a TODO in x1-el2.dtso for
> now and disable IRIS even when it was enabled by the board.
> 
> [1]: https://resources.linaro.org/en/resource/sF8jXifdb9V1mUefdbfafa
> [2]: https://lore.kernel.org/r/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/
> [3]: https://lore.kernel.org/r/20250819165447.4149674-12-mukesh.ojha@oss.qualcomm.com/
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/x1-el2.dtso | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1-el2.dtso b/arch/arm64/boot/dts/qcom/x1-el2.dtso
> index 380441deca65d1b443962fbe6151f4aadd918383..2d1c9151cf1b4aca79f7ad67328ffc3c721b9dc3 100644
> --- a/arch/arm64/boot/dts/qcom/x1-el2.dtso
> +++ b/arch/arm64/boot/dts/qcom/x1-el2.dtso
> @@ -12,6 +12,11 @@ &gpu_zap_shader {
>   	status = "disabled";
>   };
>   
> +&iris {
> +	/* TODO: Add video-firmware iommus to start IRIS from EL2 */
> +	status = "disabled";
> +};
> +
>   /*
>    * When running under Gunyah, this IOMMU is controlled by the firmware,
>    * however when we take ownership of it in EL2, we need to configure
> 
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

  reply	other threads:[~2025-09-15 11:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 10:06 [PATCH v2 0/9] arm64: dts: qcom: x1e80100: Add IRIS video codec Stephan Gerhold
2025-09-15 10:06 ` [PATCH v2 1/9] arm64: dts: qcom: sm8550/sm8650: Fix typo in IRIS comment Stephan Gerhold
2025-09-15 11:03   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 2/9] arm64: dts: qcom: x1e80100: Add IRIS video codec Stephan Gerhold
2025-09-15 10:06 ` [PATCH v2 3/9] arm64: dts: qcom: x1-el2: Disable IRIS for now Stephan Gerhold
2025-09-15 11:02   ` Bryan O'Donoghue [this message]
2025-09-15 10:06 ` [PATCH v2 4/9] arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec Stephan Gerhold
2025-09-15 11:01   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 5/9] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS Stephan Gerhold
2025-09-15 11:00   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 6/9] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: " Stephan Gerhold
2025-09-15 11:00   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 7/9] arm64: dts: qcom: x1e80100-dell-inspiron-14-plus-7441: " Stephan Gerhold
2025-09-15 10:59   ` Bryan O'Donoghue
2025-09-15 11:01   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 8/9] arm64: dts: qcom: x1e80100-dell-latitude-7455: " Stephan Gerhold
2025-09-15 10:59   ` Bryan O'Donoghue
2025-09-15 10:06 ` [PATCH v2 9/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Stephan Gerhold
2025-09-15 11:00   ` Bryan O'Donoghue
2025-09-16 16:58 ` [PATCH v2 0/9] arm64: dts: qcom: x1e80100: Add IRIS video codec Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85b6de36-4f0a-41f4-a803-77355d5da3af@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=alexey.klimov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=aruhier@mailbox.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=stefan.schmidt@linaro.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox