From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA92237713 for ; Tue, 27 Jan 2026 06:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769495213; cv=none; b=YBzay+I6MrzgY3N0Lxju8AoewpVSwVaER+xny2+WlUChqMXPmBgEPYmmpxumTDHgs/YkwJXQF+SJII/dubX9G+4J9EVpJibY6HkyV5xSLLoqUHrhRYc1zieHdaMHkfWQOdZzQxcQZF+NtiZojFn2M3wc8Sw1yqR1/SCYvspR5QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769495213; c=relaxed/simple; bh=3ZMwlMDdcZOeFSfV+NKz7u07M2f8knHtILiYPoeGklM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XMhQYWSvBEdLYL4NzyYPeRNVnHGJ7NMK5EecNfyBnw2n7KsyR66+Due1IdjMDKheNhAVFywbbtATbd3PZW4rJDhal5aAU9H6BbRCovTl1fTa6oElmX55Zs6jezlqqU5V4njUiyfsqbly42uxnvlPG9rYk10pQHVF8KIhmAPjb88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MD2gHp1h; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MD2gHp1h" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47ee07570deso40165505e9.1 for ; Mon, 26 Jan 2026 22:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769495210; x=1770100010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SWD55duaNuQRMmraETqUDpWummec5E+B5H4qqlJvJhs=; b=MD2gHp1hOmczY8b85TcOvXXekJLF/TgM/lINdHzTxvIuHa5eWNjcj6mt3FgXiMnO04 kEBNAerDLhInEdkhdrXBHgu6SHsb+eZLDAAidXux+OQdBBa0+PZlKFY+4voA4yooGW4M ZYOnlf+JZH3pEcaHPcdYaiCnEpVccwsjIGIV0cejUKD1wvkVztfInWQ0H+TqfTBwhdIm KWtcUsttNyuJ/vemqG0PBs/sN0R1QnQuUwUyF3xK6u6SAUnwGmHBpvwXNmTRfr5NqYkm ndbFPznm2illzItGmOBAUC/R/ypmiZH4qtTpviytxNdBDc/rc8eQzqbhXNRWZMFw2EBG yM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769495210; x=1770100010; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SWD55duaNuQRMmraETqUDpWummec5E+B5H4qqlJvJhs=; b=M4L4Iijs4Rz0LxDVdSfYof6Zb769yKw2R+kOQwDCwftg/ZJTE5fj8WQiRoI32vSKWU UjG/1EuqEu9B4CLPFPV8LjyQotJBhTOuBR+THavBuG7RZnk/EeoC+ebkeHimOibvQo2v XaRddwEH2gyFhTKm5ohzDHqry8sS9tItrwSZBgzJZrCvGObMT2oHDYg9m5ELr2MPS1lJ aNfk/Ez4ff88P//XQYkx4EUt0R2F4N3Xb86/vUv0BEPrIqL4yus13kdmFW4RaG3S4tFM TpdpMzSBucHWXeSmTfRRtawPWWg92YhRSYZhjIobiSR+p2S8KSk+PGIqNAjrU4MBqY5H w8+Q== X-Forwarded-Encrypted: i=1; AJvYcCVjFnUtIkD2zpz/+XDgwmhV/uKN171bX9smIWepnEqAY/x2mdCRSnQIjOS/KV1Z4xz7a1agtTATeeP/1xc=@vger.kernel.org X-Gm-Message-State: AOJu0YzjyRBE3xWhp4AdJmtwMPKwOD4+Jx2LXwPwXuCYYEzNJQyefnxq Nl3HorUZQMuNJitqUzdzAGSbSFJkNaXPhwWu6N8/qtphp4g5gegvSIhP X-Gm-Gg: AZuq6aIktVjgSc0zWkvgRMlpl8648v9NrMbwtoEUEWeO65YpN1bqBhOo5T3MAyuHFg0 4Qu0TtOHG+RQA3z1xcOVRAzwQB37IwzZx+yb5R2QMqq5qxXEJNlVDIOskqddwwEE8AHgnEH4m6h +gLqedCz4tazu4RhzqlR23MCyiCCSjfyGdezUwPZNgoVXvDW2zwSjw/i11NxZ17BNyh7xbDDmKf HlaHvZ9sg8ugQmyPE73hV2RhKcBJJ/zkzh4ZqqjudZKSrxrQ92TIwo03s/ohS3MGndhSvQ2epSs I3dHkwr5iYfkZy06Eq/XARyrAJK/uWRSxVrw49hwoHqFYhPKsUNuevPuRCyFvt/Hp+Gp9Oc7erp piSdaGwDFdIOJ72rh7owv9ljGHymJX/mlYoTP9hhDWHmLHVbn0eVhSSrwnqzMM9CxjsaZLK0nGK geOFGrpEgUKXkrUW49Cho2bNmFbJ9SXebAT9Q= X-Received: by 2002:a05:600c:8719:b0:480:1aae:676c with SMTP id 5b1f17b1804b1-48069c78706mr7026885e9.18.1769495209781; Mon, 26 Jan 2026 22:26:49 -0800 (PST) Received: from [10.221.205.245] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm42358365e9.9.2026.01.26.22.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 22:26:49 -0800 (PST) Message-ID: <85b9a197-9957-4646-8f97-5aa4d90eb415@gmail.com> Date: Tue, 27 Jan 2026 08:26:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/mlx4: fix MAC table total count corruption in __mlx4_unregister_mac() To: Kery Qi , tariqt@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: jackm@dev.mellanox.co.il, ogerlitz@mellanox.com, monis@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260122183906.2015-2-qikeyu2017@gmail.com> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20260122183906.2015-2-qikeyu2017@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/01/2026 20:39, Kery Qi wrote: > In __mlx4_unregister_mac(), when operating in mf_bonded mode > (SR-IOV with bonding), it appears that the code might be incorrectly > decrementing table->total instead of dup_table->total when cleaning > up the duplicate table entry. > > If this is the case, it would cause the primary table's total counter > to be decremented twice (once for itself and once when it should > decrement the duplicate table), leading to counter corruption. > Over time, table->total could become negative, which would > break the "table->total == table->max" fullness check in > __mlx4_register_mac(). > > The registration path correctly increments both counters: > ++table->total; > if (dup) { > ... > ++dup_table->total; > } > > However, the unregistration path seems to have a typo: > --table->total; > if (dup) { > ... > --table->total; // Should this be --dup_table->total? > > Fixes: 5f61385d2ebc2 ("net/mlx4_core: Keep VLAN/MAC tables mirrored in multifunc HA mode") > Signed-off-by: Kery Qi > --- Hi Kery, 1. Commit message is phrased as an RFC, with questions and uncertainty. Please re-phrase. 2. Do you hit an actual failure here? What are the steps? What error do you see? Other than that, code LGTM. > drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c > index e3d0b13c1610..6d0295c471da 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/port.c > +++ b/drivers/net/ethernet/mellanox/mlx4/port.c > @@ -410,7 +410,7 @@ void __mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac) > if (mlx4_set_port_mac_table(dev, dup_port, dup_table->entries)) > mlx4_warn(dev, "Fail to set mac in duplicate port %d during unregister\n", dup_port); > > - --table->total; > + --dup_table->total; > } > out: > if (dup) {