Re: [PATCH v8 0/4] net: phy: bcm5481x: add support for BroadR-Reach mode

[Florian Fainelli <florian.fainelli@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]



On 6/19/2024 4:03 PM, Kamil Horák - 2N wrote:
> PATCH 1 - Add the 10baseT1BRR_Full link mode
> 
> PATCH 2 - Add the definitions of LRE registers, necessary to use
>     BroadR-Reach modes on the BCM5481x PHY
> 
> PATCH 3 - Add brr-mode flag to switch between IEEE802.3 and BroadR-Reach
> 
> PATCH 4 - Implementation of the BroadR-Reach modes for the Broadcom
>     PHYs
> 
> Changes in v2:
>    - Divided into multiple patches, removed useless link modes
> 
> Changes in v3:
>    - Fixed uninitialized variable in bcm5481x_config_delay_swap function
> 
> Changes in v4:
>    - Improved the division of functions between bcm-phy library and broadcom.c
>    - Changed the BroadR-Reach / IEEE mode switching to device tree boolean as
>      these modes are mutually exclusive and barely could coexist in one hardware
>    - Made the link mode selection compatible with current ethtool (i.e. the
>      linkmode is selected by choosing speed and master-slave)
> 
> Changes in v5:
>    - Fixed the operator precedence as reported by the kernel test robot
>    - Fixed doc of bcm_linkmode_adv_to_mii_adv_t function
> 
> Changes in v6:
>    - Moved the brr-mode flag to separate commit as required by the rules for
>      DT binding patches
>    - Renamed some functions to make clear they handle LRE-related stuff
>    - Reordered variable definitions to match the coding style requirements
> 
> Changes in v7:
>    - Fixed the changes distribution into patches (first one was not buildable)
> 
> Changes in v8:
>    - Fixed coding style and did other changes on behalf of the reviewers

You got some Acked-by/Reviewed-by tags from reviewers from the previous 
version, why were not those carried over?
-- 
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]