CML2 1.9.6 is available

CML2 1.9.6 is available

[Eric S. Raymond]

Release 1.9.6: Sun Dec  9 03:23:55 EST 2001
	* Rulebase and help sync with 2.4.17-pre6/2.5.1-pre8.
	* Corrected casting in default computation.

The bug queue is empty.
-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

The right of the citizens to keep and bear arms has justly been considered as
the palladium of the liberties of a republic; since it offers a strong moral
check against usurpation and arbitrary power of rulers; and will generally,
even if these are successful in the first instance, enable the people to resist
and triumph over them."
        -- Supreme Court Justice Joseph Story of the John Marshall Court

Re: CML2 1.9.6 is available

[Keith Owens]

After a quick check it looks good.

One niggle, some strings for kuild 2.5 are longer than 30 characters,
cml2 restricts the string length in make menuconfig.  Only menuconfig
has this restriction, not oldconfig nor xconfig.  Can the limit be
removed, or at least changed to $ROWS-n which would adjust to screen
size?

Re: CML2 1.9.6 is available

[Eric S. Raymond]

Keith Owens <kaos@ocs.com.au>:
> One niggle, some strings for kuild 2.5 are longer than 30 characters,
> cml2 restricts the string length in make menuconfig.  Only menuconfig
> has this restriction, not oldconfig nor xconfig.  Can the limit be
> removed, or at least changed to $ROWS-n which would adjust to screen
> size?

The only place I see a limit of 30 is in the query_popup function used
for querying for things like search strings, symbol names in the go-to
command, etc. in menuconfig.

The answer is: maybe.  The underlying problem here is that the prompt
string and the string editing area both eat screen width.  30 is about
the largest limit that doesn't blow up the configurator when combined
with the longest prompt strings.
-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

Everything you know is wrong.  But some of it is a useful first approximation.

Re: CML2 1.9.6 is available

[Keith Owens]

On Wed, 12 Dec 2001 00:05:06 -0500, 
"Eric S. Raymond" <esr@thyrsus.com> wrote:
>Keith Owens <kaos@ocs.com.au>:
>> One niggle, some strings for kuild 2.5 are longer than 30 characters,
>> cml2 restricts the string length in make menuconfig.  Only menuconfig
>> has this restriction, not oldconfig nor xconfig.  Can the limit be
>> removed, or at least changed to $ROWS-n which would adjust to screen
>> size?
>
>The only place I see a limit of 30 is in the query_popup function used
>for querying for things like search strings, symbol names in the go-to
>command, etc. in menuconfig.
>
>The answer is: maybe.  The underlying problem here is that the prompt
>string and the string editing area both eat screen width.  30 is about
>the largest limit that doesn't blow up the configurator when combined
>with the longest prompt strings.

This works for me.

--- cml2-1.9.6/cmlconfigure.py	Sun Dec  9 19:27:31 2001
+++ 2.4.16-kbuild-2.5/scripts/cmlconfigure.py	Wed Dec 12 17:23:01 2001
@@ -1009,7 +1009,7 @@
 
     def query_popup(self, prompt, initval=None):
         "Pop up a window to accept a string."
-        maxsymwidth = 30	# Constant
+        maxsymwidth = self.columns - len(prompt) - 2
         if initval and len(initval) > maxsymwidth:
             self.help_popup("PRESSANY", (lang["TOOLONG"],), beep=1) 
             return initval

Warning, that is my first bit of Python code (Oh no, now I'm
contaminated too :-).

Re: CML2 1.9.6 is available

[Eric S. Raymond]

Keith Owens <kaos@ocs.com.au>:
> This works for me.
> 
> --- cml2-1.9.6/cmlconfigure.py	Sun Dec  9 19:27:31 2001
> +++ 2.4.16-kbuild-2.5/scripts/cmlconfigure.py	Wed Dec 12 17:23:01 2001
> @@ -1009,7 +1009,7 @@
>  
>      def query_popup(self, prompt, initval=None):
>          "Pop up a window to accept a string."
> -        maxsymwidth = 30	# Constant
> +        maxsymwidth = self.columns - len(prompt) - 2
>          if initval and len(initval) > maxsymwidth:
>              self.help_popup("PRESSANY", (lang["TOOLONG"],), beep=1) 
>              return initval
> 
> Warning, that is my first bit of Python code (Oh no, now I'm
> contaminated too :-).

And a very nice bit it is too :-).

I actually ended up making a similar change shortly after I wrote you.

Right now I'm testing Jan Harknes's CML1 backport patch.
-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

I do not find in orthodox Christianity one redeeming feature.
	-- Thomas Jefferson

Re: CML2 1.9.6 is available

[Lars Brinkhoff]

"Eric S. Raymond" <esr@thyrsus.com> writes:
> Right now I'm testing Jan Harknes's CML1 backport patch.

It's the second time I see this CML1 backport mentioned.  You sure you
don't mean the Python1 backport?

-- 
Lars Brinkhoff          http://lars.nocrew.org/     Linux, GCC, PDP-10
Brinkhoff Consulting    http://www.brinkhoff.se/    programming

Re: CML2 1.9.6 is available

[Eric S. Raymond]

Lars Brinkhoff <lars.spam@nocrew.org>:
> "Eric S. Raymond" <esr@thyrsus.com> writes:
> > Right now I'm testing Jan Harknes's CML1 backport patch.
> 
> It's the second time I see this CML1 backport mentioned.  You sure you
> don't mean the Python1 backport?

Sorry, that is what I meant.
-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

"Those who make peaceful revolution impossible 
will make violent revolution inevitable."
	-- John F. Kennedy