From: Dave Hansen <dave.hansen@intel.com>
To: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
seanjc@google.com, kim.phillips@amd.com,
kirill.shutemov@linux.intel.com, jmattson@google.com,
babu.moger@amd.com, kai.huang@intel.com, acme@redhat.com,
aik@amd.com, namhyung@kernel.org
Cc: CobeChen@zhaoxin.com, TimGuo@zhaoxin.com, LeoLiu-oc@zhaoxin.com,
GeorgeXue@zhaoxin.com
Subject: Re: [PATCH v2 1/3] crypto: padlock-sha: Matches CPU with Family with 6 explicitly
Date: Wed, 31 Jan 2024 07:33:36 -0800 [thread overview]
Message-ID: <85dd3df3-9c0e-45e2-af8d-50dbc0cf40c8@intel.com> (raw)
In-Reply-To: <40e74749-fa9d-4089-ae23-e9aefdd3549f@zhaoxin.com>
On 1/31/24 01:45, Tony W Wang-oc wrote:
>>> static const struct x86_cpu_id padlock_sha_ids[] = {
>>> - X86_MATCH_FEATURE(X86_FEATURE_PHE, NULL),
>>> + X86_MATCH_VENDOR_FAM_FEATURE(CENTAUR, 6, X86_FEATURE_PHE, NULL),
>>> {}
>>> };
>> Logically, this is saying that there are non-CENTAUR or non-family-6
>> CPUs that set X86_FEATURE_PHE, but don't support X86_FEATURE_PHE. Is
>> that the case?
>
> Not exactly.
>
> Zhaoxin CPU supports X86_FEATURE_PHE and X86_FEATURE_PHE2.
>
> We expect the Zhaoxin CPU to use the zhaoxin_sha driver introduced in
> the third patch of this patch set.
>
> Without this patch Zhaoxin CPU will also match the padlock-sha driver too.
I honestly have no idea what this is saying.
Could you try again, please?
next prev parent reply other threads:[~2024-01-31 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 2:28 [PATCH v2 0/3] Add Zhaoxin hardware engine driver support for SHA Tony W Wang-oc
2024-01-23 2:28 ` [PATCH v2 1/3] crypto: padlock-sha: Matches CPU with Family with 6 explicitly Tony W Wang-oc
2024-01-23 16:33 ` Dave Hansen
2024-01-31 9:45 ` Tony W Wang-oc
2024-01-31 15:33 ` Dave Hansen [this message]
2024-02-01 2:37 ` Tony W Wang-oc
2024-02-01 16:42 ` Dave Hansen
2024-01-23 2:28 ` [PATCH v2 2/3] x86/cpufeatures: Add CPU feature flags for Zhaoxin Hash Engine Tony W Wang-oc
2024-01-23 9:44 ` Borislav Petkov
2024-01-23 15:42 ` H. Peter Anvin
2024-01-23 16:00 ` Borislav Petkov
2024-01-31 8:59 ` Tony W Wang-oc
2024-01-23 2:28 ` [PATCH v2 3/3] crypto: Zhaoxin: Hardware Engine Driver for SHA1/256/384/512 Tony W Wang-oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85dd3df3-9c0e-45e2-af8d-50dbc0cf40c8@intel.com \
--to=dave.hansen@intel.com \
--cc=CobeChen@zhaoxin.com \
--cc=GeorgeXue@zhaoxin.com \
--cc=LeoLiu-oc@zhaoxin.com \
--cc=TimGuo@zhaoxin.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=acme@redhat.com \
--cc=aik@amd.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=kai.huang@intel.com \
--cc=kim.phillips@amd.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox