Re: [PATCH 02/18] property: Add support for calling fwnode_graph_get_endpoint_by_id() for fwnode->secondary

Laurent Pinchart
2020-11-30T18:42:44Z

Hi Andy,

On Mon, Nov 30, 2020 at 07:53:19PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 30, 2020 at 07:28:57PM +0200, Laurent Pinchart wrote:
> > On Mon, Nov 30, 2020 at 07:29:00PM +0200, Andy Shevchenko wrote:
> > > On Mon, Nov 30, 2020 at 01:31:13PM +0000, Daniel Scally wrote:
>
> ...
>
> > > > + if (!best_ep && fwnode && !IS_ERR_OR_NULL(fwnode->secondary))
> > > > + return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port,
> > > > + endpoint, flags);
> > >
> > > > return best_ep;
> > >
> > > Can we, please, do
> > >
> > > if (best_ep)
> > > return best_ep;
> > >
> > > if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary))
> > > return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port,
> > > endpoint, flags);
> > >
> > > return NULL;
> > >
> > > ?
> > >
> > > This 'if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary))' becomes kinda
> > > idiomatic to the cases when we need to proceed primary followed by the
> > > secondary in cases where it's not already done.
> >
> > We could also move the !fwnode check to the beginning of the function.
>
> It's already there (1). What did I miss?

It is, but as we need an explicitly check at the end, it feels cleaner
to move it to the beginning. No big deal though.

> 1) via fwnode_graph_get_next_endpoint() -> fwnode_call_ptr_op()

--
Regards,

Laurent Pinchart