Re: [PATCH 03/18] software_node: Fix failure to put() and get() references to children in software_node_get_next_child()

Laurent Pinchart
2020-11-30T16:11:46Z

Hi Daniel,

Thank you for the patch.

On Mon, Nov 30, 2020 at 01:31:14PM +0000, Daniel Scally wrote:
> The software_node_get_next_child() function currently does not hold
> references to the child software_node that it finds or put the ref that
> is held against the old child - fix that.
>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes since RFC v3:
>
> Put reference to previous child.
>
> drivers/base/swnode.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 010828fc785b..615a0c93e116 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -443,14 +443,18 @@ software_node_get_next_child(const struct fwnode_handle *fwnode,
> struct swnode *c = to_swnode(child);
>
> if (!p || list_empty(&p->children) ||
> - (c && list_is_last(&c->entry, &p->children)))
> + (c && list_is_last(&c->entry, &p->children))) {
> + fwnode_handle_put(child);
> return NULL;
> + }
>
> if (c)
> c = list_next_entry(c, entry);
> else
> c = list_first_entry(&p->children, struct swnode, entry);
> - return &c->fwnode;
> +
> + fwnode_handle_put(child);
> + return fwnode_handle_get(&c->fwnode);
> }
>
> static struct fwnode_handle *

--
Regards,

Laurent Pinchart