From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikram Sharma <vikram.sharma@oss.qualcomm.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Suresh Vankadara <svankada@qti.qualcomm.com>,
Prashant Shrotriya <pshrotri@qti.qualcomm.com>
Subject: Re: [PATCH 1/6] dt-bindings: media: Add bindings for qcom,glymur-camss
Date: Fri, 29 May 2026 16:07:38 +0100 [thread overview]
Message-ID: <8618255e-ecbf-4f55-877d-09cb2faa6f50@linaro.org> (raw)
In-Reply-To: <20260529-glymur_camss-v1-1-bee535396d22@oss.qualcomm.com>
On 29/05/2026 15:37, Vikram Sharma wrote:
> +
> + vdd-csiphy-0p8-supply:
> + description:
> + Phandle to 0.8V regulator supply to CSI PHYs.
> +
> + vdd-csiphy-1p2-supply:
> + description:
> + Phandle to a 1.2V regulator supply to CSI PHYs pll block.
> +
To be brutally honest, I'd rather see effort and buy-in from qcom
engineers in converting to CSIPHY as a distinct sub-node.
Pushing patches to hit your own internal deadlines to the detriment of
upstream quality is not OK.
This binding should be predicated on separate CSIPHY nodes. I've
published... three perhaps four versions of that patch to radio silence
on your side.
---
bod
next prev parent reply other threads:[~2026-05-29 15:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 14:37 [PATCH 0/6] Add CAMSS support for Qualcomm Glymur Vikram Sharma
2026-05-29 14:37 ` [PATCH 1/6] dt-bindings: media: Add bindings for qcom,glymur-camss Vikram Sharma
2026-05-29 15:07 ` Bryan O'Donoghue [this message]
2026-05-30 12:23 ` Krzysztof Kozlowski
2026-06-01 11:24 ` Dmitry Baryshkov
2026-06-01 14:38 ` Bryan O'Donoghue
2026-05-29 14:37 ` [PATCH 2/6] dt-bindings: i2c: qcom-cci: Document Glymur compatible Vikram Sharma
2026-05-30 14:09 ` Wolfram Sang
2026-06-04 23:39 ` Andi Shyti
2026-05-29 14:37 ` [PATCH 3/6] media: qcom: camss: Add " Vikram Sharma
2026-05-30 12:25 ` Krzysztof Kozlowski
2026-05-29 14:37 ` [PATCH 4/6] media: qcom: camss: Add CSIPHY support for Glymur Vikram Sharma
2026-05-29 14:37 ` [PATCH 5/6] media: qcom: camss: enable vfe " Vikram Sharma
2026-05-29 14:50 ` Bryan O'Donoghue
2026-06-01 11:09 ` Nihal Kumar Gupta
2026-06-01 11:31 ` Dmitry Baryshkov
2026-06-01 13:01 ` Nihal Kumar Gupta
2026-06-01 13:55 ` Dmitry Baryshkov
2026-06-01 14:19 ` Bryan O'Donoghue
2026-05-30 12:25 ` Krzysztof Kozlowski
2026-05-29 14:37 ` [PATCH 6/6] media: qcom: camss: Enumerate resources " Vikram Sharma
2026-05-30 12:27 ` Krzysztof Kozlowski
2026-06-01 13:33 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8618255e-ecbf-4f55-877d-09cb2faa6f50@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=pshrotri@qti.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=svankada@qti.qualcomm.com \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox