Re: [PATCH 3/3] mailbox: zynqmp: Remove invalid __percpu annotation in zynqmp_ipi_probe()

Michal Simek
2024-12-13T15:06:12Z

On 12/13/24 15:57, Uros Bizjak wrote:
> struct zynqmp_ipi_pdata __percpu *pdata is not a per-cpu variable,
> so it shoul not be annotated with __percpu annotation.

typo here.

>
> Remove invalid __percpu annotation to fix several
>
> zynqmp-ipi-mailbox.c:920:15: warning: incorrect type in assignment (different address spaces)
> zynqmp-ipi-mailbox.c:920:15: expected struct zynqmp_ipi_pdata [noderef] __percpu *pdata
> zynqmp-ipi-mailbox.c:920:15: got void *
> zynqmp-ipi-mailbox.c:927:56: warning: incorrect type in argument 3 (different address spaces)
> zynqmp-ipi-mailbox.c:927:56: expected unsigned int [usertype] *out_value
> zynqmp-ipi-mailbox.c:927:56: got unsigned int [noderef] __percpu *
> ...
>
> and several
>
> drivers/mailbox/zynqmp-ipi-mailbox.c:924:9: warning: dereference of noderef expression
> ...
>
> sparse warnings.
>
> There were no changes in the resulting object files.
>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: Michal Simek <michal.simek@amd.com>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index aa5249da59b2..0c143beaafda 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -905,7 +905,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *nc, *np = pdev->dev.of_node;
> - struct zynqmp_ipi_pdata __percpu *pdata;
> + struct zynqmp_ipi_pdata *pdata;
> struct of_phandle_args out_irq;
> struct zynqmp_ipi_mbox *mbox;
> int num_mboxes, ret = -EINVAL;

Feel free to also find commit which introduced this issue and add
Fixes and cc: stable to v2.

Thanks,
Michal