From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434F5C77B7C for ; Tue, 9 May 2023 07:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234916AbjEIH7Z (ORCPT ); Tue, 9 May 2023 03:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234658AbjEIH7H (ORCPT ); Tue, 9 May 2023 03:59:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C39BAAD0E for ; Tue, 9 May 2023 00:57:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1428644DC for ; Tue, 9 May 2023 07:56:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05131C433D2; Tue, 9 May 2023 07:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683618990; bh=Wd8Bj8emXZqkveQu4K7hNYr5Jv+UrU1Q7duR/S6Ekzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YbUKH1eFtrCM+scAUYSDkZzJywiSiGS4/OPTRbYelydqtZFho53jtiy+d0UfTjXLF PP0Wb3mKAHEyaKnBaInUceG++mCmIGMoMUnRZbSKEX8zSrSlcd/Aj31dzjCLHJWqey qaxljpLdqXNnVD2Y4JPJKZrO3uMLq5lp2Dp+p6Ws2lPPzlzPxbAwpfyEvt+dL2vfIu +ZXqj6ORD++eADINlUmkXBaLNAMiMnJ00n+2bHwI6zEpUS5F8MOZZQeSdqSsIEpJ+j UQMhISvxG/TG2UGTnNKEGYCPsPrQ87rmLD84c6t5NylBo33MA0TnvsaL9OrJRNAHy4 ZyZtirgfu2afw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pwICx-00Dp6F-Kp; Tue, 09 May 2023 08:56:27 +0100 Date: Tue, 09 May 2023 08:56:27 +0100 Message-ID: <861qjqndjo.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Russell King , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: perf: Mark all accessor functions inline In-Reply-To: <3a7d9bc7470aa2d85696ee9765c74f8c03fb5454.1683561482.git.geert+renesas@glider.be> References: <3a7d9bc7470aa2d85696ee9765c74f8c03fb5454.1683561482.git.geert+renesas@glider.be> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: geert+renesas@glider.be, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 May 2023 17:05:18 +0100, Geert Uytterhoeven wrote: >=20 > When just including : >=20 > arch/arm/include/asm/arm_pmuv3.h:110:13: error: =E2=80=98write_pmevty= pern=E2=80=99 defined but not used [-Werror=3Dunused-function] > 110 | static void write_pmevtypern(int n, unsigned long val) > | ^~~~~~~~~~~~~~~~ > arch/arm/include/asm/arm_pmuv3.h:103:13: error: =E2=80=98write_pmevcn= trn=E2=80=99 defined but not used [-Werror=3Dunused-function] > 103 | static void write_pmevcntrn(int n, unsigned long val) > | ^~~~~~~~~~~~~~~ > arch/arm/include/asm/arm_pmuv3.h:95:22: error: =E2=80=98read_pmevcntr= n=E2=80=99 defined but not used [-Werror=3Dunused-function] > 95 | static unsigned long read_pmevcntrn(int n) > | ^~~~~~~~~~~~~~ >=20 > Fix this by adding the missing "inline" keywords to the three accessor > functions that lack them. >=20 > Fixes: 009d6dc87a568db6 ("ARM: perf: Allow the use of the PMUv3 driver on= 32bit ARM") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Marc Zyngier M. --=20 Without deviation from the norm, progress is not possible.