Re: badly punctuated parameter list in `#define' (2.4.3-ac5 and 2.4.4 -pre2)

Christoph Hellwig
2001-04-12T19:32:33Z

In article <86256A2C.0068BA0C.00@smtpnotes.altec.com> you wrote:
>
> When compiling 2.4.3-ac5 (and also 2.4.4-pre2) I get this:
>
> /usr/src/linux-2.4.3-ac5/include/asm/rwsem.h:26: badly punctuated parameter list
> in `#define'
>
> This appears to be due to some code in rwsem.h that is written for a different
> version of gcc. (I'm still using gcc-2.91.66 as specified in
> Documentation/Changes.) It works for me if I replace it with the code in the
> section labeled /* old gcc */. Here's a patch to do that:

So the /* old gcc */ part should probably be enabled based on a define for the
old compiler. The right ifdef seems to be:

#if __GNUC__ == 2 && __GNUC_MINOR__ < 95

Could you test it this way?

Christoph

--
Of course it doesn't work. We've performed a software upgrade.