From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A58326A0DD; Tue, 11 Nov 2025 09:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762854546; cv=none; b=rofJN24vak5EWi4zVn71gqX2KrP+JMibSwyojFAbxROLeCUcKWxiYdGqAluyd924PhoHuoVrL8X1u8wjOkfCsAALGPPY0xcO2p4Os1yVcpQz7uYmi0PXzXbu5aBhhC/nzNLpxrLrQQm+0vWuZre+vEDucYj+M710Di14wkH0cSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762854546; c=relaxed/simple; bh=n/kM1AzkAh+XotAdnnKzHeaD66yI0/no2z219kdImyI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=XOYTEH2oqGZFc4noenf5d2TSqSZVbayKtkdRKHn8i3VmhYQ7jYYJ19zT3dC4Z4oO+kgdJ/b7Ob7N2tlGEUHQ7iimiFeImhRS5i/Fp9u815xBXbBtFcVu5+Q5vMJ9Qkfb3mjFRc4GhcFo/ZYB6fGK1WNgJGjgjDjhTkIuFEpKzYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HOeJ3RVZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HOeJ3RVZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB372C19421; Tue, 11 Nov 2025 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762854546; bh=n/kM1AzkAh+XotAdnnKzHeaD66yI0/no2z219kdImyI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HOeJ3RVZZB/4oSIYEvD8eHEipzvZOFaJqnkE42dmMFp+tB9OuzjLWz04+YM3z7R4U lcaEalhowL1o71cerk5eX47EHL+ajre+fi2UEyJi1xInplcb7+DTXcolqUX2R5nGjK 6MBMS9grqKVToRjoS/YeVP7uQixVgsoLfttes1N01Nh3coRsXQHPgvQXU4w4kWOnxq iTV9Sv5znQ/WVyipDX6Eh5zMTxj++G97cXGP2KglHW5b3TIN+Akg5PHoftE2jnkGiu Nq4Ktn6Go9uKbNUmiwWIpZYgET9XI++vRz/VbZK/uBooblkYrgAlMYga9XRb72DXVa aZdMFVmKrv7Fg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vIkzn-00000004Alt-2bIR; Tue, 11 Nov 2025 09:49:03 +0000 Date: Tue, 11 Nov 2025 09:49:03 +0000 Message-ID: <86346kvr00.wl-maz@kernel.org> From: Marc Zyngier To: Osama Abdelkader Cc: oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: add missing newline to sysreg init log In-Reply-To: <20251110211051.814728-1-osama.abdelkader@gmail.com> References: <20251110211051.814728-1-osama.abdelkader@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: osama.abdelkader@gmail.com, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 10 Nov 2025 21:10:51 +0000, Osama Abdelkader wrote: > > missing newline so the message is merged with follow-on logs > the change only affects console output formatting, no behavioral impact. > > Signed-off-by: Osama Abdelkader > --- > arch/arm64/kvm/arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 870953b4a8a7..156cd1a6106e 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void) > > err = kvm_sys_reg_table_init(); > if (err) { > - kvm_info("Error initializing system register tables"); > + kvm_info("Error initializing system register tables\n"); > return err; > } > Given that everything in kvm_sys_reg_table_init() already screams badly when it fails, I don't see the point of an additional message, and I'd rather remove it. Thanks, M. -- Without deviation from the norm, progress is not possible.