From: Marc Zyngier <maz@kernel.org>
To: Nianyao Tang <tangnianyao@huawei.com>
Cc: <tglx@linutronix.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <guoyang2@huawei.com>,
<wangwudi@hisilicon.com>, <wangzhou1@hisilicon.com>,
<jiangkunkun@huawei.com>, <guozicheng3@hisilicon.com>
Subject: Re: [PATCH V2] irqchip/gic-v4.1:Check whether indirect table is supported in allocate_vpe_l1_table
Date: Fri, 26 Sep 2025 09:47:14 +0100 [thread overview]
Message-ID: <8634891tyl.wl-maz@kernel.org> (raw)
In-Reply-To: <20250918141557.1791041-1-tangnianyao@huawei.com>
On Thu, 18 Sep 2025 15:15:57 +0100,
Nianyao Tang <tangnianyao@huawei.com> wrote:
>
> In allocate_vpe_l1_table, it allocates a new vpe table without checking
> whether indirect table is supported.
> ARM allows vendors to support only flat tables. Let's first check if
> indirect tables are supported before using it.
>
> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
As I understand it, this is for the same machines that also requires
[1] and [2] to be able to use vLPIs and vSGIs.
I seriously doubt that we want *any* of it (creating userspace ABI to
deal with a broken design is not something I'm keen on).
Frankly, you should consider disabling GICv4.1 on these machines, and
stick with GICv3 (which I assume works correctly).
Thanks,
M.
[1] https://lore.kernel.org/r/20250825023954.3516381-1-wangzhou1@hisilicon.com
[2] https://lore.kernel.org/r/20250909110615.129179-1-wangzhou1@hisilicon.com
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2025-09-26 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 14:15 [PATCH V2] irqchip/gic-v4.1:Check whether indirect table is supported in allocate_vpe_l1_table Nianyao Tang
2025-09-26 8:47 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634891tyl.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=guoyang2@huawei.com \
--cc=guozicheng3@hisilicon.com \
--cc=jiangkunkun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangnianyao@huawei.com \
--cc=tglx@linutronix.de \
--cc=wangwudi@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox