From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 582972AE68 for ; Sun, 19 Jul 2026 02:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784428904; cv=none; b=nK21YNYscu8QMtwyg0SP4S/tJzNODhH7DfTGfgq0FwCAFrDRLeN2QZ0DYAhdrd0vro6tGbA1tylaDo8AlV5k2MZsUHSm8JswCxL7G3tT4Dic9HVIbuR3wYavBGXx4l/0NjqRO1GE5CoURrAQnS1q2BhXRT4pIfmCqysXJ0/V2Ks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784428904; c=relaxed/simple; bh=T+IMYh0kKqAALiojNf0eEsOBjqE5iDv5moDtT6Yy9JE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=senDvX2kIpPNwM1la1QRYdFhRCQeyPN4z3MAbbwOmv7INkOp97vEnnIm5IIfbE58dIfo16eJXJJHMiCQK8ZZnFwCvkCuM/YgkzSKbfgD/A8lUgDjGe3xgMxtv3fnB1ytFoZ35jTPFUxtvZRn3qqOi31BkPH+bNkvgSZbmnoS4/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Sn+IkZmx; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Sn+IkZmx" Message-ID: <8638d68c-4bb8-476f-97d3-98f433949ab7@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784428891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtJfWQYyZlCwt5055dITLF3UyUsl6gTusWicTltj6lI=; b=Sn+IkZmxVcsADg16l30+ATSEaY8uJkAhyNOphUNHjIaw8UCaqKBtlZKexW6tdh3K9+GfnH UTdm+7r3MIfSQssOQt9fNOudr/eabf+Czmmr60JitM0bLarweEl99lXQVdETNYyq5SKo1I DdRqhEjo6LAyxTlfFl2KfyfnlxBU0NM= Date: Sun, 19 Jul 2026 10:41:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] net: dsa: realtek: rtl8365mb: use devm_mutex_init To: Luiz Angelo Daros de Luca , Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718-realtek_mutext-v1-1-1cd7beb20ae6@gmail.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qingfang Deng In-Reply-To: <20260718-realtek_mutext-v1-1-1cd7beb20ae6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi Luiz, On 7/18/2026 1:59 PM, Luiz Angelo Daros de Luca wrote: > mutex_destroy() is needed while debugging mutex. Instead of calling it > directly on driver .remove(), just use devm. > > Signed-off-by: Luiz Angelo Daros de Luca > --- > drivers/net/dsa/realtek/rtl8365mb_main.c | 15 ++++++++++++--- > drivers/net/dsa/realtek/rtl83xx.c | 14 +++++++++++--- > 2 files changed, 23 insertions(+), 6 deletions(-) As you're fixing a missing teardown, and the two files were introduced at different times, you should split your patch into two (one for each file), re-target your series to the "net" tree, and add a Fixes tag respectively. Best regards, Qingfang