From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761557AbcIXI6h (ORCPT ); Sat, 24 Sep 2016 04:58:37 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:61707 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756764AbcIXI6f (ORCPT ); Sat, 24 Sep 2016 04:58:35 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: sre@kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] HSI: omap_ssi_core: move function declaration to header file Date: Sat, 24 Sep 2016 10:58:15 +0200 Message-ID: <8643667.VP5CpNPstK@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474693916-11789-1-git-send-email-baoyou.xie@linaro.org> References: <1474693916-11789-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:W7ycO4qFoZBg0lBxHW0Q90tia+tCHU0erCnG/pp8/8Vgctdu2+l lFUX0la7Qb/p5+K+zFcGRnUIn96hVqywLFOi+nNhgjb5By6OJmSqG5645J43QQV9QVdmlEe 43sY+hoXef1/5NjyZhn4byAbOCf1euX2yBs9F7p2UMetYR8eWKEdFdc/KUo1yCDZtzQ5m6t FIpCtO5RPJoagn9c9S+Xg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7Fzr2f2to/M=:fPw3RyZUorhrCWdr6jFtTb gVgz2wG9dXXPC34uIuTta8jG1yubUVWKTbmHSYkSKGUsQN3k7foEPtuuLNCnDGaD86W+ooQDF QAKImYGYcgQ98Uyly8tCDqp0W8Z1J63Sj+osq8sB8m9JA7mXNXJr+1u82wx+4XDtJKi5g+NpL 5mCtPO4V7h9HPzigmwZEktSFEtJgF74iTG9CxWldchzrPJX/RfFKuvFtZIV/9P/Mee6kpDKxT jSNU1UhcuaueQkGWbHdC4eF6bG63xr7N23bBBDIzWNHTuVOnOFcf9JtxEabK/BoqHa1KFn9Ze 2w19PnLdZGDmYDD2zXUvs/nQsdhWgBqfk00DWnGXeCPqAU6ujADzSJ/a0YXcCyNK5GYdEUIqT GJQurA0dLzIErgPCa8E9rdRJ6taQPxgib7Q+EPSzcOdzbeiT8waZTPJOs3xVDdMSwwL2cIHuu nLD3jnHEA2K7gslzy6GLGxr23Ykclidmd4ZYX4OFcsta05u2BateUYxcktBaW6fydfbCqkwzv 22MQ9E/lGv8yLQm3ANXDw+iJsoFZNvRhAYPUQTe7thGlkc6Z3aNR9hMTXC4wtDo2yTexk8CY9 1Z0hk4Vfbyv+iRSiNH4cE47rjMGxuqdf/W1bzGFgmqe0OWcq0TKYpXgAt/g/vrw/Pddt0DQkf RB3HEagK/o3bLGYrg9Pt3s+aYKnmk4duRrNnpc7PnEj12NRQFqCJ8pwe6vv8lIrDCsWHRu/Jn CYBQ2B6kXosfgKwk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 1:11:56 PM CEST Baoyou Xie wrote: > --- > drivers/hsi/clients/ssi_protocol.c | 2 -- > include/linux/hsi/hsi.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c > index 6031cd1..fe86444 100644 > --- a/drivers/hsi/clients/ssi_protocol.c > +++ b/drivers/hsi/clients/ssi_protocol.c > @@ -45,8 +45,6 @@ > #include > #include > > -void ssi_waketest(struct hsi_client *cl, unsigned int enable); > - > #define SSIP_TXQUEUE_LEN 100 > #define SSIP_MAX_MTU 65535 > #define SSIP_DEFAULT_MTU 4000 > Maybe the declaration should be moved to include/linux/hsi/ssi_protocol.h instead of include/linux/hsi/hsi.h? It's not completely clear as the exported function is a bit of a layering violation. Arnd