* [PATCH] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
@ 2024-08-19 9:10 Ma Ke
2024-08-19 9:45 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Ma Ke @ 2024-08-19 9:10 UTC (permalink / raw)
To: maz, tglx, Suravee.Suthikulpanit, akpm
Cc: linux-arm-kernel, linux-kernel, Ma Ke, stable
Add the missing of_node_put() to release the refcount incremented
by of_find_matching_node().
Cc: stable@vger.kernel.org
Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/irqchip/irq-gic-v2m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index 51af63c046ed..65a55ee7bb30 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -396,6 +396,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,
ret = of_address_to_resource(child, 0, &res);
if (ret) {
pr_err("Failed to allocate v2m resource.\n");
+ of_node_put(child);
break;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
2024-08-19 9:10 [PATCH] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init Ma Ke
@ 2024-08-19 9:45 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2024-08-19 9:45 UTC (permalink / raw)
To: Ma Ke
Cc: tglx, Suravee.Suthikulpanit, akpm, linux-arm-kernel, linux-kernel,
stable
On Mon, 19 Aug 2024 10:10:11 +0100,
Ma Ke <make24@iscas.ac.cn> wrote:
>
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().
>
> Cc: stable@vger.kernel.org
> Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/irqchip/irq-gic-v2m.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
> index 51af63c046ed..65a55ee7bb30 100644
> --- a/drivers/irqchip/irq-gic-v2m.c
> +++ b/drivers/irqchip/irq-gic-v2m.c
> @@ -396,6 +396,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,
> ret = of_address_to_resource(child, 0, &res);
> if (ret) {
> pr_err("Failed to allocate v2m resource.\n");
> + of_node_put(child);
> break;
> }
>
Although this indeed fixes a minor issue, it is probably better to
unify all the failure conditions. Something like this (untested):
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index 51af63c046ed..d5988012eb40 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -407,12 +407,12 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,
ret = gicv2m_init_one(&child->fwnode, spi_start, nr_spis,
&res, 0);
- if (ret) {
- of_node_put(child);
+ if (ret)
break;
- }
}
+ if (ret && child)
+ of_put_node(child);
if (!ret)
ret = gicv2m_allocate_domains(parent);
if (ret)
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
@ 2023-10-07 7:54 Ma Ke
0 siblings, 0 replies; 3+ messages in thread
From: Ma Ke @ 2023-10-07 7:54 UTC (permalink / raw)
To: tglx, maz; +Cc: linux-kernel, Ma Ke
Add the missing of_node_put() to release the refcount incremented
by of_find_matching_node().
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/irqchip/irq-gic-v2m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index f2ff4387870d..d3e54c557b4c 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -427,6 +427,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,
ret = of_address_to_resource(child, 0, &res);
if (ret) {
pr_err("Failed to allocate v2m resource.\n");
+ of_node_put(child);
break;
}
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-19 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 9:10 [PATCH] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init Ma Ke
2024-08-19 9:45 ` Marc Zyngier
-- strict thread matches above, loose matches on Subject: below --
2023-10-07 7:54 Ma Ke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox