From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D2EE92FFE for ; Fri, 6 Oct 2023 10:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231651AbjJFKUx (ORCPT ); Fri, 6 Oct 2023 06:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231611AbjJFKUv (ORCPT ); Fri, 6 Oct 2023 06:20:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F12299F for ; Fri, 6 Oct 2023 03:20:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A352C433C8; Fri, 6 Oct 2023 10:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696587649; bh=X9o6NEtPOaUbt8J9+hy7Oi+szPetgHfUiy3SgUBoKO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XyaAxD5qXPrzWL1HHeK+LKQ9vuZyiDhjiDjrYaWkESMLdr1SpEOa7smYi/lcMHwZh 43qtR0tqviPOiuNRkYpf73iLkqLysp+tvCtrR1R+64s1bFltlqMFjifCCwmqoQ0MD7 ZTMWBhxXY3korwJZmDzzbkw4vre+4TcbsEuFmWYVpR5wAzoT938LbJvAaHUJoMdtcj xOiWXCwhmkb2jCYbgQFfV9bsYqCDsxfHvrudRPb0We+HQAVEH6Yc0bsg+ABGmvuLG3 w6kn3TAjPFvfhwaFLgdThRGiuAREGCRiaS/F0WPw2dD+GNhKDxHiH4PnmnUKu6msvN 2oJCpAmz72lBg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qohws-001g4t-8h; Fri, 06 Oct 2023 11:20:46 +0100 Date: Fri, 06 Oct 2023 11:20:44 +0100 Message-ID: <864jj4njb7.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: Doug Anderson , Catalin Marinas , Will Deacon , Stephen Boyd , Valentin Schneider , Chen-Yu Tsai , AngeloGioacchino Del Regno , D Scott Phillips , Josh Poimboeuf , Matthias Brugger , Misono Tomohiro , Peter Zijlstra , Sumit Garg , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] arm64: smp: Fix pseudo NMI issues w/ broken Mediatek FW In-Reply-To: References: <20231002094526.1.Ie8f760213053e3d11592f892b30912dbac6b8b48@changeid> <86jzs2ofqs.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, dianders@chromium.org, catalin.marinas@arm.com, will@kernel.org, swboyd@chromium.org, vschneid@redhat.com, wenst@chromium.org, angelogioacchino.delregno@collabora.com, scott@os.amperecomputing.com, jpoimboe@kernel.org, matthias.bgg@gmail.com, misono.tomohiro@fujitsu.com, peterz@infradead.org, sumit.garg@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Oct 2023 11:27:26 +0100, Mark Rutland wrote: > 3) Partial fix: make the ARM64_HAS_GIC_PRIO_MASKING cpucap depend on the > absence of a "mediatek,broken-save-restore-fw" property in the DT. I believe > we can check that in early_enable_pseudo_nmi() or can_use_gic_priorities(). > > That'll avoid potential issues if/when we change the priorities used for > pNMI (which is something I've been looking at). > > I'm happy with (3) if Marc is. Definitely worth investigating if you have the bandwidth. M. -- Without deviation from the norm, progress is not possible.