public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Regression: Revert "Bluetooth: use buffer priority to mark URB_ISO_ASAP flag"
Date: Mon, 23 Jan 2012 09:16:47 -0800	[thread overview]
Message-ID: <864nvmuyo0.fsf@sumi.keithp.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1201231019580.1372-100000@iolanthe.rowland.org>

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Mon, 23 Jan 2012 10:23:14 -0500 (EST), Alan Stern <stern@rowland.harvard.edu> wrote:

> Well, if the DEBUG code never changed any behaviors at all, it would be 
> pretty useless, wouldn't it?

A WARN_ON would have been sufficient to catch attention without breaking
an otherwise working system.

This is certainly the first time I've ever encountered DEBUG code that
did anything more than print out information to help developers debug
stuff...

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2012-01-23 17:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23  5:58 [PATCH] Regression: Revert "Bluetooth: use buffer priority to mark URB_ISO_ASAP flag" Keith Packard
2012-01-23  9:03 ` Marcel Holtmann
2012-01-23  9:18   ` Johan Hedberg
2012-01-23 15:23 ` Alan Stern
2012-01-23 17:16   ` Keith Packard [this message]
2012-02-02 10:50 ` Pavel Machek
2012-02-02 20:38   ` [PATCH] USB: debugging code shouldn't alter control flow Alan Stern
2012-02-04 15:49     ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864nvmuyo0.fsf@sumi.keithp.com \
    --to=keithp@keithp.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox