make menuconfig - cosmetic question

make menuconfig - cosmetic question

[Martin.Knoblauch]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Hi,

 this is most likely just a small issue. If I knew where to look, I
would try to fix it and submit a patch :-)

 When I diff config files pocessed by "make [old]config" and "make
menueconfig", it seems that menuconfig is not writing out some of the
"comments" that the other versions do write. This is of course nothing
serious, but it ticks me off. Any idea where to look for this glitch?

Thanks
Martin
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
IT Services              |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Card for Martin.Knoblauch --]
[-- Type: text/x-vcard; charset=us-ascii; name="Martin.Knoblauch.vcf", Size: 381 bytes --]

begin:vcard 
n:Knoblauch;Martin
tel;cell:+49-170-4904759
tel;fax:+49-89-510857-111
tel;work:+49-89-510857-309
x-mozilla-html:FALSE
url:http://www.teraport.de
org:TeraPort GmbH;IT-Services
adr:;;Garmischer Straße 4;München;Bayern;D-80339;Germany
version:2.1
email;internet:Martin.Knoblauch@TeraPort.de
title:Senior System Engineer
x-mozilla-cpt:;32160
fn:Martin Knoblauch
end:vcard

Re: make menuconfig - cosmetic question

[Bjorn Wesen]

While we're on cosmetics... how about imprisonment for the person who
chose yellow on light grey for the first letters in each option... 

/Bjorn

On Thu, 17 May 2001, Martin.Knoblauch wrote:
>  this is most likely just a small issue. If I knew where to look, I
> would try to fix it and submit a patch :-)
> 
>  When I diff config files pocessed by "make [old]config" and "make
> menueconfig", it seems that menuconfig is not writing out some of the
> "comments" that the other versions do write. This is of course nothing
> serious, but it ticks me off. Any idea where to look for this glitch?

Re: make menuconfig - cosmetic question

[Martin.Knoblauch]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

Bjorn Wesen wrote:
> 
> While we're on cosmetics... how about imprisonment for the person who
> chose yellow on light grey for the first letters in each option...
> 
> /Bjorn
> 
> On Thu, 17 May 2001, Martin.Knoblauch wrote:
> >  this is most likely just a small issue. If I knew where to look, I
> > would try to fix it and submit a patch :-)
> >
> >  When I diff config files pocessed by "make [old]config" and "make
> > menueconfig", it seems that menuconfig is not writing out some of the
> > "comments" that the other versions do write. This is of course nothing
> > serious, but it ticks me off. Any idea where to look for this glitch?

 Now, changing that color is simple. Just change the value of TAG_KEY_FG
in scripts/lxdialog/colors.h. Unfortunatelly, this is not a question of
cosmetics, but taste. And I do not want to go into that :-)

 After some browsing around the Menuconfig script and not really
understanding how it works :-), I found the line to change. At least now
the config files look identical when processed with menuconfig (except
the fisrt comment, of course):

--- linux/Scripts/Menuconfig.orig     Thu May 17 17:19:21 2001
+++ linux/scripts/Menuconfig  Thu May 17 17:17:25 2001
@@ -1250,7 +1250,7 @@
        function comment () {
                if [ "$comment_is_option" ]
                then
-                       comment_is_option=
+                       comment_is_option=TRUE
                        echo        >>$CONFIG
                        echo "#"    >>$CONFIG
                        echo "# $1" >>$CONFIG

 Not sure whether this is worth to put into the next release - maybe
someone can spend two minutes to crosscheck.

Martin
PS: Sorry for the MIME. Should not have happend :-( Hope it is better
now.
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
IT Services              |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Card for Martin.Knoblauch --]
[-- Type: text/x-vcard; charset=us-ascii; name="Martin.Knoblauch.vcf", Size: 381 bytes --]

begin:vcard 
n:Knoblauch;Martin
tel;cell:+49-170-4904759
tel;fax:+49-89-510857-111
tel;work:+49-89-510857-309
x-mozilla-html:FALSE
url:http://www.teraport.de
org:TeraPort GmbH;IT-Services
adr:;;Garmischer Straße 4;München;Bayern;D-80339;Germany
version:2.1
email;internet:Martin.Knoblauch@TeraPort.de
title:Senior System Engineer
x-mozilla-cpt:;32160
fn:Martin Knoblauch
end:vcard

Re: make menuconfig - cosmetic question

[Martin.Knoblauch]

"Martin.Knoblauch" wrote:
> 
> 
>  Not sure whether this is worth to put into the next release - maybe
> someone can spend two minutes to crosscheck.
> 

 This looks more complete. 

lx/linux > diff -u scripts/Menuconfig.orig scripts/Menuconfig
--- scripts/Menuconfig.orig     Thu May 17 17:19:21 2001
+++ scripts/Menuconfig  Thu May 17 18:10:22 2001
@@ -74,7 +74,10 @@
 # - Implemented new functions: define_tristate(), define_int(),
define_hex(),
 #   define_string(), dep_bool().
 #
-
+# 17 May 2001, Martin Knoblauch, <knobi@knobisoft.de>
+# - Fix output of comment strings to .config/autoconfig.h so that they
equal
+#   the comments from "make [old]config"
+#

 #
 # Change this to TRUE if you prefer all kernel options listed
@@ -1240,7 +1243,7 @@
        }
 
        function mainmenu_option () {
-               comment_is_option=TRUE
+               :
        }
 
        function endmenu () {
@@ -1248,9 +1251,7 @@
        }
 
        function comment () {
-               if [ "$comment_is_option" ]
-               then
-                       comment_is_option=
+
                        echo        >>$CONFIG
                        echo "#"    >>$CONFIG
                        echo "# $1" >>$CONFIG
@@ -1260,7 +1261,6 @@
                        echo "/*"    >>$CONFIG_H
                        echo " * $1" >>$CONFIG_H
                        echo " */"   >>$CONFIG_H
-               fi
        }
 
        echo -n "."

Martin
PS: This time without vcard ...
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
IT Services              |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759

sniffer

[gis88530]

Dear all,

Do you know that why tcpdump will loss some packet passing in the subnet?
Sorry, I mean that if there are 99Mbps packet in the ethernet, 
but tcpdump just find out 80Mbps packet. Why?

What thing affect packet loss?
Thanks

Tom

Re: make menuconfig - cosmetic question

[Keith Owens]

On Thu, 17 May 2001 16:07:40 +0200, 
"Martin.Knoblauch" <Martin.Knoblauch@TeraPort.de> wrote:
>This is a multi-part message in MIME format.

Please turn off MIME when sending to linux-kernel, especially those
useless vcards at the end of your mail.

> When I diff config files pocessed by "make [old]config" and "make
>menueconfig", it seems that menuconfig is not writing out some of the
>"comments" that the other versions do write.

Congratulations, you have found reason #93 for replacing the current
configuration system (CML1) with something better - CML1 has multiple
parsers with subtly different rules and output.  CML2 will fix this, in
kernel 2.5.