From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752674AbbJJVCb (ORCPT <rfc822;w@1wt.eu>);
	Sat, 10 Oct 2015 17:02:31 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:64016 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752556AbbJJVC3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 10 Oct 2015 17:02:29 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Russell King <linux@arm.linux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 5/5] arm: add missing of_node_put
Date: Sat, 10 Oct 2015 23:02:15 +0200
Message-ID: <8655275.vMqHQfLN9g@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr>
References: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr> <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:C6ufmYJSIiDxfTpLrT/QOUvhdo3Cllgcf0QGVkHHchCd+ycsjze
 BU+vTe1M5yaHZ5+IwxzsAI8Lkw3rW1aape/gbDBkXbLP20oGVOjDDxLXBv2HWoyiEuz7Cy0
 NB7Q0UOXU56qFfLB8GsJ8HkI+fOdSbNOfCAMbPNe8v1IL0KsMmYk2hTZRWNA4XwfW42Jh5X
 +BcvHmX3CWtsHwkZJjylQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TN80MR1Yblo=:DHeNtjqU1ZDrkWfmYtxv36
 EknuiGjrvpwS+rr+FdzOz1FJgOdpRLKp4DfhKJ+yRLfD/j26B1e9/vmVYJx2rOk5XZTtKAwKM
 kLNUEvR4jWkQ3VD6za/PSV5bORyxBEgrSae7zOSWQQJI11hTKhfTkIg/YVS43UwiPq3ZPzQOZ
 zrzSH4ALkZmdbv5uBA74g3lhQcrt6wqEJqqlBmzjAwgVTZQH8ZnzZfHhe/2UY+S0kYJhsXjWP
 IAFuEmrygZ8m/dbDZw2nsmoMnQck7E9hSrE8U87OHcg8OizU+4GMwG1uFzSEjfhtPYWmbMxwt
 JLGydP5qHeeLiP30JflzmdHqmWNIHLgPy/Buxs3iCTGmrA2irAG2b+c+XD73BX6Z+YX2LYjNx
 IP6rMwFnjfqzylpnToMo8VEKz0O6mY7EyPTpMauaofS9Fl5q36rFg8BOWh4YYvl00cewFKcEP
 FhgkysVqHJjiBm3WKntBjQoEYAeR7G4LGG6Iq9NxW8XZs6uYu1bveH9SurEr1pC8iafmztxGq
 ZiUb9es4G0VNMDYY0lEPJpnppc7Q+2nHEuvu5oBG8KV/3mv4CVWIu4HuiLQdTmVK2pAA3fpEY
 zhjzcKSZkEqexycqCeAX9QAEUdF/XgOpRHc+XWhFGvMMztm+ckyntuTZyaVK/W72b8I28ZLRS
 SUVlw+qPq7JOkNMx2RDoFIahmNU0T5YG7xLDC5Ga1h5OsRLZMYEThm6IjvJSnp6gM7aXZqXJM
 W1O2VSPwZsxok65Q
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 10 October 2015 14:30:54 Julia Lawall wrote:
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index 11c54de..432ff34 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -143,6 +143,7 @@ void __init arm_dt_init_cpu_maps(void)
>                                                "max cores %u, capping them\n",
>                                                cpuidx, nr_cpu_ids)) {
>                         cpuidx = nr_cpu_ids;
> +                       of_node_put(cpu);
>                         break;
>                 }
> 

The same for_each_child_of_node() loop has three 'return' statements'
aside from the 'break' statement here. I think you should change your
semantic patch to cover both cases.

	Arnd